[PATCH v2 0/4] connected: search promisor objects generically
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Jun 24, 2026, 10:37 UTC
- Message-ID
- <20260624-pks-connected-generic-promisor-checks-v2-0-132d73ee47b9@pks.im>
- In-Reply-To
- <20260622-pks-connected-generic-promisor-checks-v1-0-25eba2698202@pks.im>
Hi,
this patch series refactors "connected.c" so that we search for promisor objects in a generic way instead of reaching into internal of the object database. As a result, the connectivity checks will work properly in repos that don't use packfiles in the first place.
The series is built on top of 8d96f09e92 (Merge branch 'js/objects-larger-than-4gb-on-windows', 2026-06-19) with ps/odb-source-packed at 1bba3c035d (odb/source-packed: drop pointer to "files" parent source, 2026-06-17) merged into it.
Changes in v2:
- Fix the accidentally-dropped call to `odb_reprepare()`.
- Add a preparatory commit that splits out `check_connected_promisor()`.
I think also splitting out `check_connected_rev_list()` would only
have diminishing returns, so I skipped that part.
- Link to v1: https://patch.msgid.link/20260622-pks-connected-generic-promisor-checks-v1-0-25eba2698202@pks.imThanks!
Patrick
---
Patrick Steinhardt (4):
odb/source-packed: extract logic to skip certain packs
odb/source-packed: support flags when iterating an object prefix
connected: split out promisor-based connectivity check
connected: search promisor objects genericallyconnected.c | 95 ++++++++++++++++++++++++++++++++++------------------- odb/source-packed.c | 50 ++++++++++++++++++++-------- 2 files changed, 98 insertions(+), 47 deletions(-)
Range-diff versus v1:
1: 6ff1fc8d89 = 1: a1a1af0fc6 odb/source-packed: extract logic to skip certain packs 2: 1022a1fdcc = 2: bd81a9e478 odb/source-packed: support flags when iterating an object prefix 3: 102fab7df2 < -: ---------- connected: search promisor objects generically -: ---------- > 3: f39ef68c3e connected: split out promisor-based connectivity check -: ---------- > 4: 558f30a6f2 connected: search promisor objects generically
--- base-commit: 4a8e7a446f41435e157131162dfe901eca9250fe change-id: 20260612-pks-connected-generic-promisor-checks-2933bff3028d