[PATCH 0/7] setup: drop global state
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Jun 10, 2026, 06:56 UTC
- Message-ID
- <20260610-b4-pks-setup-drop-global-state-v1-0-5dff3eec8f06@pks.im>
Hi,
this patch series continues to refactor "setup.c", where the focus is to drop remaining global state that we have in "setup.c". The most important consequence of this is that we don't need to rely on `the_repository` in `is_bare_repository()` anymore.
This series is built on top of 1ff279f340 (The 13th batch, 2026-06-09) with ps/setup-centralize-odb-creation at 42b9d3dc9d (setup: construct object database in `apply_repository_format()`, 2026-06-04) merged into it.
Thanks!
Patrick
---
Patrick Steinhardt (7):
builtin/init: stop modifying global `git_work_tree_cfg` variable
builtin/init: simplify logic to configure worktree
setup: remove global `git_work_tree_cfg` variable
builtin/init: stop modifying `is_bare_repository_cfg`
environment: split up concerns of `is_bare_repository_cfg`
environment: stop using `the_repository` in `is_bare_repository()`
treewide: drop USE_THE_REPOSITORY_VARIABLEattr.c | 4 ++-- builtin/bisect.c | 2 +- builtin/blame.c | 2 +- builtin/check-attr.c | 2 +- builtin/fetch.c | 2 +- builtin/gc.c | 2 +- builtin/history.c | 2 +- builtin/init-db.c | 44 +++++++++++++++++++++++++++----------------- builtin/repack.c | 3 +-- builtin/repo.c | 2 +- builtin/reset.c | 2 +- builtin/rev-parse.c | 2 +- environment.c | 10 +++------- environment.h | 6 ++---- git.c | 2 +- mailmap.c | 6 ++---- refs/files-backend.c | 2 +- refs/reftable-backend.c | 4 +--- repository.c | 1 + repository.h | 7 +++++++ setup.c | 45 ++++++++++++++++++++++++--------------------- setup.h | 6 ++++++ transport.c | 4 ++-- worktree.c | 4 ++-- 24 files changed, 91 insertions(+), 75 deletions(-)
--- base-commit: f5a08a09a0fdf0fc2a355eba7979e2cfd65659e5 change-id: 20260422-b4-pks-setup-drop-global-state-6b1374aed5db