git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 5/8] t7810: turn MB_REGEX check into a lazy prereq

From
Jeff King <peff@peff.net>
Date
Jun 9, 2026, 01:22 UTC
Message-ID
<20260609012236.GA1502349@coredump.intra.peff.net>
In-Reply-To
<20260604-pks-t7527-fix-tap-output-v3-5-7d766ed481e4@pks.im>
On Thu, Jun 04, 2026 at 12:07:35PM +0200, Patrick Steinhardt wrote:
Show 13 quoted lines
> diff --git a/t/t7810-grep.sh b/t/t7810-grep.sh
> index 1b195bee59..d61c4a4d73 100755
> --- a/t/t7810-grep.sh
> +++ b/t/t7810-grep.sh
> @@ -18,8 +18,9 @@ test_invalid_grep_expression() {
>  	'
>  }
>  
> -LC_ALL=en_US.UTF-8 test-tool regex '^.$' '¿' &&
> -  test_set_prereq MB_REGEX
> +test_lazy_prereq MB_REGEX '
> +	LC_ALL=en_US.UTF-8 test-tool regex "^.$" "¿"
> +'

Oh good. Since the error was coming from the shell, I was worried that the use of LC_ALL inside the test snippets was somehow causing output to leak to stderr. But it was just (yet another) case where we ran a tool outside of a snippet, which is easy to fix.

This also allays my fears that the tests might have been misbehaving on those other platforms. They are (and were) caught by this prereq and not run at all, which is the right thing.

Thanks for fixing.
-Peff
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 15 of 18 in “t: fix broken TAP output”
  1. 0/4 t: fix broken TAP outputPatrick Steinhardt, Jun 2, 2026
  2. 1/4 t7527: fix broken TAP outputPatrick Steinhardt, Jun 2, 2026
  3. 2/4 t/test-lib: silence EBUSY errors on Windows during test cleanupPatrick Steinhardt, Jun 2, 2026
  4. 3/4 t/lib-git-p4: silence output when killing p4d and its watchdogPatrick Steinhardt, Jun 2, 2026
  5. Junio C HamanoJun 2, 2026
  6. Patrick SteinhardtJun 2, 2026
  7. Junio C HamanoJun 2, 2026
  8. 4/4 t: let prove fail when parsing invalid TAP outputPatrick Steinhardt, Jun 2, 2026
  9. 0/8 t: fix broken TAP outputPatrick Steinhardt, Jun 4, 2026
  10. 1/8 gitlab-ci: rearrange Linux jobs to match GitHub's orderPatrick Steinhardt, Jun 4, 2026
  11. 2/8 gitlab-ci: add missing Linux jobsPatrick Steinhardt, Jun 4, 2026
  12. 3/8 ci: unify Linux images across GitLab and GitHubPatrick Steinhardt, Jun 4, 2026
  13. 4/8 t7527: fix broken TAP outputPatrick Steinhardt, Jun 4, 2026
  14. 5/8 t7810: turn MB_REGEX check into a lazy prereqPatrick Steinhardt, Jun 4, 2026
  15. Jeff KingJun 9, 2026
  16. 6/8 t/test-lib: silence EBUSY errors on Windows during test cleanupPatrick Steinhardt, Jun 4, 2026
  17. 7/8 t/lib-git-p4: silence output when killing p4d and its watchdogPatrick Steinhardt, Jun 4, 2026
  18. 8/8 t: let prove fail when parsing invalid TAP outputPatrick Steinhardt, Jun 4, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.