git/list[1] front-page[2] threads[3] people[4] search[5] about
wed 2026-10-07 16:59 UTC

[PATCH] compat/mingw: Allow SIGKILL to kill in mingw_kill.

From
Siddh Raman Pant <siddh.raman.pant@oracle.com>
Date
May 22, 2026, 06:16 UTC
Message-ID
<20260522061652.50078-1-siddh.raman.pant@oracle.com>
mingw_kill() only allows SIGTERM for killing a process.

Let's also allow the natural SIGKILL for the same so that callers don't have to do ifdef soup for special Windows handling.

Signed-off-by: Siddh Raman Pant <siddh.raman.pant@oracle.com>
---
 compat/mingw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/compat/mingw.c b/compat/mingw.c
index aa7525f419cb..00a994aa9f47 100644
--- a/compat/mingw.c
+++ b/compat/mingw.c
@@ -2250,7 +2250,7 @@ int mingw_execvp(const char *cmd, char *const *argv)
 
 int mingw_kill(pid_t pid, int sig)
 {
-	if (pid > 0 && sig == SIGTERM) {
+	if (pid > 0 && (sig == SIGTERM || sig == SIGKILL)) {
 		HANDLE h = OpenProcess(PROCESS_TERMINATE, FALSE, pid);
 
 		if (TerminateProcess(h, -1)) {
-- 
2.53.0
Next: Junio C Hamano
Message 1 of 5 in “compat/mingw: Allow SIGKILL to kill in mingw_kill.”
  1. compat/mingw: Allow SIGKILL to kill in mingw_kill.Siddh Raman Pant, May 22, 2026
  2. Junio C HamanoMay 22, 2026
  3. Siddh Raman PantMay 22, 2026
  4. Johannes SchindelinMay 28, 2026
  5. Junio C HamanoMay 28, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.