git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 0/4] approxidate: tweak special date formats

From
Tuomas Ahola <taahol@utu.fi>
Date
May 16, 2026, 15:15 UTC
Message-ID
<20260516151540.9611-1-taahol@utu.fi>
In-Reply-To
<20260514115520.6660-1-taahol@utu.fi>

The approxidate system is an endless source of absurdities. Let's make the usual "eh, that's crazy, let's do better with this input" type of fix[1], and tweak some sharp edge cases, including one noticed by Linus back in 2006[2].

After this series, "tea" and "noon" will work predictably with all kinds of date formats (today, yesterday, last Friday, January 5th, one year ago yesterday...) regardless of the current time of day.

More importantly, approxidate is taught about "today", meaning by default the last midnight, as discussed in the RFC thread.[3]

Links:
  1. https://lore.kernel.org/git/20181115144854.GB16450@sigill.intra.peff.net/
  2. https://lore.kernel.org/git/Pine.LNX.4.64.0610101102560.3952@g5.osdl.org/
  3. https://lore.kernel.org/git/20260515205803.26211-1-taahol@utu.fi/
Tuomas Ahola (4):
  approxidate: make "today" wrap to midnight
  t0006: add support for approxidate test date adjustment
  approxidate: make "specials" respect fixed day-of-month
  approxidate: use deferred mday adjustments for "specials"
 Documentation/rev-list-options.adoc |  3 +-
 date.c                              | 45 ++++++++++++++++++++++-------
 t/t0006-date.sh                     | 43 ++++++++++++++++++++++++++-
 3 files changed, 79 insertions(+), 12 deletions(-)
Intervall-diff mot v3:
-:  ---------- > 1:  86bcb70ac2 approxidate: make "today" wrap to midnight
1:  7ea9c9967b = 2:  9863f359a1 t0006: add support for approxidate test date adjustment
2:  3a21727dbe < -:  ---------- approxidate: alias "today" to "now"
3:  d1992d23d0 = 3:  830de02f74 approxidate: make "specials" respect fixed day-of-month
4:  0b1a10305c ! 4:  d33195dc91 approxidate: use deferred mday adjustments for "specials"
    @@ Commit message
         field for deferred date adjustments which can be easily reverted, so
         that the default logic of the special formats only applies if we don't
         get any explicit date (mday) specification.  In particular, overwrite
    -    the field with -1 in "now" and "yesterday", so that those formats will
    +    the field with -1 in "today" and "yesterday", so that those formats will
         be relative to the current date.  That makes specifications like "tea
         yesterday" behave more sensibly: instead of going backwards to the
         last tea-time and then a day back, Git will now understand that as the
    @@ date.c: void datestamp(struct strbuf *out)
      	if (tm->tm_mon < 0)
      		tm->tm_mon = now->tm_mon;
      	if (tm->tm_year < 0) {
    -@@ date.c: static void pending_number(struct tm *tm, int *num)
    - static void date_now(struct tm *tm, struct tm *now, int *num)
    - {
    - 	*num = 0;
    -+	tm->tm_mday = -1;
    - 	update_tm(tm, now, 0);
    - }
    - 
    +@@ date.c: static void date_now(struct tm *tm, struct tm *now, int *num)
      static void date_yesterday(struct tm *tm, struct tm *now, int *num)
      {
      	*num = 0;
    @@ date.c: static void pending_number(struct tm *tm, int *num)
      }
      
      static void date_pm(struct tm *tm, struct tm *now UNUSED, int *num)
    +@@ date.c: static void date_today(struct tm *tm, struct tm *now, int *num UNUSED)
    + 	if (tm->tm_hour == now->tm_hour &&
    + 	    tm->tm_min == now->tm_min &&
    + 	    tm->tm_sec == now->tm_sec)
    +-		date_time(tm, now, 0);
    ++		date_time(tm, 0);
    ++	tm->tm_mday = -1;
    + 	update_tm(tm, now, 0);
    + }
    + 
     
      ## t/t0006-date.sh ##
     @@ t/t0006-date.sh: check_approxidate '3:00' '2009-08-30 03:00:00'
base-commit: 94f057755b7941b321fd11fec1b2e3ca5313a4e0
-- 
2.30.2
Previous: Tuomas AholaNext: Tuomas Ahola
Message 24 of 36 in “approxidate: tweak special date formats”
  1. 0/2 approxidate: tweak special date formatsTuomas Ahola, Mar 18, 2025
  2. 2/2 approxidate: overwrite tm_mday for `now` and `yesterday`Tuomas Ahola, Mar 18, 2025
  3. Jeff KingApr 4, 2025
  4. 1/2 approxidate: make "specials" respect fixed day-of-monthTuomas Ahola, Mar 18, 2025
  5. Jeff KingApr 4, 2025
  6. 0/3 approxidate: tweak special date formatsTuomas Ahola, May 12, 2026
  7. 1/3 t0006: add support for approxidate test date adjustmentTuomas Ahola, May 12, 2026
  8. Junio C HamanoMay 12, 2026
  9. Jeff KingMay 12, 2026
  10. 2/3 approxidate: make "specials" respect fixed day-of-monthTuomas Ahola, May 12, 2026
  11. Junio C HamanoMay 12, 2026
  12. 3/3 approxidate: use deferred mday adjustments for "specials"Tuomas Ahola, May 12, 2026
  13. 0/4 approxidate: tweak special date formatsTuomas Ahola, May 14, 2026
  14. 2/4 approxidate: alias "today" to "now"Tuomas Ahola, May 14, 2026
  15. Junio C HamanoMay 14, 2026
  16. Tuomas AholaMay 14, 2026
  17. Junio C HamanoMay 15, 2026
  18. Junio C HamanoMay 15, 2026
  19. Tuomas AholaMay 15, 2026
  20. 1/4 t0006: add support for approxidate test date adjustmentTuomas Ahola, May 14, 2026
  21. 3/4 approxidate: make "specials" respect fixed day-of-monthTuomas Ahola, May 14, 2026
  22. Junio C HamanoMay 14, 2026
  23. 4/4 approxidate: use deferred mday adjustments for "specials"Tuomas Ahola, May 14, 2026
  24. 0/4 approxidate: tweak special date formatsTuomas Ahola, May 16, 2026
  25. 4/4 approxidate: use deferred mday adjustments for "specials"Tuomas Ahola, May 16, 2026
  26. fixup! approxidate: use deferred mday adjustments for "specials"Tuomas Ahola, May 18, 2026
  27. 2/4 t0006: add support for approxidate test date adjustmentTuomas Ahola, May 16, 2026
  28. 1/4 approxidate: make "today" wrap to midnightTuomas Ahola, May 16, 2026
  29. 3/4 approxidate: make "specials" respect fixed day-of-monthTuomas Ahola, May 16, 2026
  30. 0/4 approxidate: tweak special date formatsTuomas Ahola, May 21, 2026
  31. 1/4 approxidate: make "today" wrap to midnightTuomas Ahola, May 21, 2026
  32. 3/4 approxidate: make "specials" respect fixed day-of-monthTuomas Ahola, May 21, 2026
  33. 4/4 approxidate: use deferred mday adjustments for "specials"Tuomas Ahola, May 21, 2026
  34. 2/4 t0006: add support for approxidate test date adjustmentTuomas Ahola, May 21, 2026
  35. Junio C HamanoMay 21, 2026
  36. Tuomas AholaMay 21, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.