Re: UBSan failing on expensive test(s)
On Sat, May 16, 2026 at 08:43:07AM +0900, Junio C Hamano wrote:
Show 16 quoted lines
> This started happening on 'next' that runs EXPENSIVE tests thanks to
> Dscho's recent updates to enable them in CI.
>
> https://github.com/git/git/actions/runs/25896439353/job/76110441841#step:10:2172
>
> It claims that """
>
> commit.c:1574:6: runtime error: signed integer overflow:
> -2147483648 - 1 cannot be represented in type 'int'
>
> """.
>
> Another is related in the sense that it used to be hidden behind
> EXPENSIVE prerequisite, but is probably unrelated.
>
> https://github.com/git/git/actions/runs/25896439353/job/76110441842#step:10:156
These patches should fix both.
[1/2]: apply: plug leak on "patch too large" error
[2/2]: commit: handle large commit messages in utf8 verification
apply.c | 6 ++++--
commit.c | 31 +++++++++++++++----------------
2 files changed, 19 insertions(+), 18 deletions(-)
-Peff