[PATCH v4 0/3] Avoid hardcoded "good"/"bad" bisect terms
- From
- Jonas Rebmann <kernel@schlaraffenlan.de>
- Date
- May 14, 2026, 09:07 UTC
- Message-ID
- <20260514-bisect-terms-v4-0-b3e3cf1b06ce@schlaraffenlan.de>
While checking whether all output messages of git bisect were covered by [PATCH 1/3] bisect: use selected alternate terms in status output I found hardcoded good/bad refs leading to incompatibility of git rev-parse --bisect with alternate bisect run terms. This is addressed by [PATCH 3/3] rev-parse: use selected alternate terms to look up refs
Signed-off-by: Jonas Rebmann <kernel@schlaraffenlan.de> --- Changes in v4: - Always print bisect terms in single quote (Thanks, Junio) - Split out quoting of bisect terms into separate commit - Link to v3: https://patch.msgid.link/20260417-bisect-terms-v3-0-d659fa547261@schlaraffenlan.de
Changes in v3: - when referencing newly introduced terms, reference them in single quotes (Thanks, Phillip) - Prefer test_grep over grep in updated Tests (Thanks, Phillip) - Improve commit messages (Thanks, Phillip) - Don't leak memory after read_bisect_terms() (Thanks, Phillip) - Don't leak memory after xstrfmt() (Thanks, Junio) - Add test case to patch 2/2 - Link to v2: https://patch.msgid.link/20260323-bisect-terms-v2-0-8d6bdb2c9c7e@schlaraffenlan.de
Changes in v2: - Improve commit message - Add tests - Include second patch for hardcoded good/bad in rev-parse - Link to v1: https://lore.kernel.org/r/20260320-bisect-terms-v1-1-c30c9540542a@schlaraffenlan.de
---
Jonas Rebmann (3):
bisect: use selected alternate terms in status output
bisect: print bisect terms in single quotes
rev-parse: use selected alternate terms to look up refsbisect.c | 16 +++--- builtin/bisect.c | 31 ++++++----- builtin/rev-parse.c | 15 +++++- t/t1500-rev-parse.sh | 25 +++++++++ t/t6030-bisect-porcelain.sh | 124 ++++++++++++++++++++++++-------------------- 5 files changed, 131 insertions(+), 80 deletions(-) --- base-commit: 59ff4886a579f4bc91e976fe18590b9ae02c7a08 change-id: 20260320-bisect-terms-76036676769c
Best regards, -- Jonas Rebmann <kernel@schlaraffenlan.de>