[PATCH v3 0/2] builtin/maintenance: fix locking and respect "gc.auto"
- From
Patrick Steinhardt <ps@pks.im>
- Date
- May 13, 2026, 07:31 UTC
- Message-ID
- <20260513-pks-maintenance-fix-lock-with-detach-v3-0-f27a1ac82891@pks.im>
- In-Reply-To
- <20260511-pks-maintenance-fix-lock-with-detach-v1-0-ccd7d62c9a40@pks.im>
Hi,
this patch series addresses the issues reported in [1]. The series is built on top of Git 2.54.0.
Changes in v3: - Use Taylor's approach to reassign all tempfiles when daemonizing. - Link to v2: https://patch.msgid.link/20260512-pks-maintenance-fix-lock-with-detach-v2-0-dc6f2d284b6d@pks.im
Changes in v2:
- Clarify comment when dropping ownership of the lock in the parent
process.
- Properly treat "gc.auto" as an integer, not a boolean.
- Link to v1: https://patch.msgid.link/20260511-pks-maintenance-fix-lock-with-detach-v1-0-ccd7d62c9a40@pks.imThanks!
Patrick
[1]: <CAKcFC3arsYExb5dCMQspo4V9UFDadFaj8Q4PUsMWZJw_eYrMzA@mail.gmail.com>
---
Patrick Steinhardt (2):
builtin/maintenance: fix locking with "--detach"
run-command: honor "gc.auto" for auto-maintenancerun-command.c | 10 ++++-- setup.c | 16 +++++++++- setup.h | 15 +++++++++ t/t7900-maintenance.sh | 83 ++++++++++++++++++++++++++++++++++++++++++++++++++ tempfile.c | 12 ++++++++ tempfile.h | 11 +++++++ 6 files changed, 143 insertions(+), 4 deletions(-)
Range-diff versus v2:
1: 5eb608ad43 < -: ---------- builtin/maintenance: fix locking with "--detach" -: ---------- > 1: 3fc8872f36 builtin/maintenance: fix locking with "--detach" 2: 15e2ae8104 = 2: 665a6c9a50 run-command: honor "gc.auto" for auto-maintenance
--- base-commit: 13ef77ce6e222bef3ab145642e6ef1486075211c change-id: 20260511-pks-maintenance-fix-lock-with-detach-a608e9b6adeb