[PATCH v2] t6112: avoid tilde expansion
- From
SZEDER Gábor <szeder.dev@gmail.com>
- Date
- Apr 21, 2026, 19:21 UTC
- Message-ID
- <20260421192132.51172-1-szeder.dev@gmail.com>
- In-Reply-To
- <20260418163236.2382826-1-szeder.dev@gmail.com>
e987df5fe6 (list-objects-filter: implement composite filters, 2019-06-27) introduced a test to "t6112-rev-list-filters-objects.sh" that checks the output of a Git command with the following commands:
grep ~$omitted_1 actual && grep ~$omitted_2 actual && grep ~$omitted_3 actual &&
Since the leading tilde in the pattern is not quoted/escaped, it is subject to tilde expansion. So if the system has a user whose username happens to be "$omitted_1", then "grep" would look for that user's home directory.
Quote those words starting with a tilde to avoid this.
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com> --- Same diff, updated commit message.
t/t6112-rev-list-filters-objects.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/t6112-rev-list-filters-objects.sh b/t/t6112-rev-list-filters-objects.sh index 39211ef989..e0a825bccf 100755 --- a/t/t6112-rev-list-filters-objects.sh +++ b/t/t6112-rev-list-filters-objects.sh @@ -623,9 +623,9 @@ test_expect_success 'verify collecting omits in combined: filter' ' omitted_2=$(echo a | git hash-object --stdin) && omitted_3=$(echo abcde | git hash-object --stdin) && - grep ~$omitted_1 actual && - grep ~$omitted_2 actual && - grep ~$omitted_3 actual && + grep "~$omitted_1" actual && + grep "~$omitted_2" actual && + grep "~$omitted_3" actual && test_line_count = 3 actual '
-- 2.54.0.655.g69726bb9dc