[PATCH v3 0/2] Avoid hardcoded "good"/"bad" bisect terms
- From
- Jonas Rebmann <kernel@schlaraffenlan.de>
- Date
- Apr 17, 2026, 16:48 UTC
- Message-ID
- <20260417-bisect-terms-v3-0-d659fa547261@schlaraffenlan.de>
While checking whether all output messages of git bisect were covered by [PATCH 1/2] bisect: use selected alternate terms in status output I found hardcoded good/bad refs leading to incompatibility of git rev-parse --bisect with alternate bisect run terms. This is addressed by [PATCH 2/2] rev-parse: use selected alternate terms to look up refs
Signed-off-by: Jonas Rebmann <kernel@schlaraffenlan.de> --- Changes in v3: - when referencing newly introduced terms, reference them in single quotes (Thanks, Phillip) - Prefer test_grep over grep in updated Tests (Thanks, Phillip) - Improve commit messages (Thanks, Phillip) - Don't leak memory after read_bisect_terms() (Thanks, Phillip) - Don't leak memory after xstrfmt() (Thanks, Junio) - Add test case to patch 2/2 - Link to v2: https://patch.msgid.link/20260323-bisect-terms-v2-0-8d6bdb2c9c7e@schlaraffenlan.de
Changes in v2: - Improve commit message - Add tests - Include second patch for hardcoded good/bad in rev-parse - Link to v1: https://lore.kernel.org/r/20260320-bisect-terms-v1-1-c30c9540542a@schlaraffenlan.de
---
Jonas Rebmann (2):
bisect: use selected alternate terms in status output
rev-parse: use selected alternate terms to look up refsbuiltin/bisect.c | 23 +++++++++++++---------- builtin/rev-parse.c | 15 +++++++++++++-- t/t1500-rev-parse.sh | 25 +++++++++++++++++++++++++ t/t6030-bisect-porcelain.sh | 38 +++++++++++++++++++++++++------------- 4 files changed, 76 insertions(+), 25 deletions(-) --- base-commit: 1b296b0f55885fa8fc649c4b31c37f3d86f3f9cf change-id: 20260320-bisect-terms-76036676769c
Best regards, -- Jonas Rebmann <kernel@schlaraffenlan.de>