Re: [PATCH v14 12/13] fsmonitor: add tests for Linux

From: Paul Tarjan <paul@paultarjan.com>
Date: Apr 15, 2026, 13:26 UTC
Message-ID: <20260415132615.47913-1-github@paulisageek.com>
In-Reply-To: <20260414221335.GA3413665@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Do we need to put it in curly braces to avoid interfering with the &&
> chain? Otherwise a failure of anything before the maybe_timeout will hit
> the "||".

Good point. Fixed in v15:

  stop_daemon_delete_repo () {
      r=$1 &&
      { maybe_timeout 30 git -C $r fsmonitor--daemon stop 2>/dev/null || :; } &&
      rm -rf $1
  }

Thanks for catching this. The broken &&-chain and 2>/dev/null were hiding the test_might_fail error.

Verified that test_might_fail rejects maybe_timeout (exit code 1, command never runs), while the { ... || :; } version actually executes the stop. No other instances of test_might_fail maybe_timeout in the repo.

Paul