[PATCH 00/12] t: detect errors outside of test cases
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Apr 13, 2026, 09:49 UTC
- Message-ID
- <20260413-b4-pks-tests-with-set-e-v1-0-5b83763a0e84@pks.im>
Hi,
this is a follow-up to the recent discussion we had around `set -e` to make our tests more robust and basically supersedes Junio's [1].
I've tested the patches with both Bash and Dash, and all tests are passing on my machine with both of them. CI seems to be happy, as well. But I would expect that this change probably has some fallout, even though I hope that it's generally going to be small and contained.
This series is based on 8c9303b1ff (Merge branch 'jc/no-writev-does-not-work', 2026-04-10).
Thanks!
Patrick
[1]: <20260325062114.2067946-1-gitster@pobox.com>
---
Patrick Steinhardt (12):
t: prepare `test_match_signal ()` calls for `set -e`
t: prepare `test_must_fail ()` for `set -e`
t: prepare `stop_git_daemon ()` for `set -e`
t: prepare `git config --unset` calls for `set -e`
t: prepare conditional test execution for `set -e`
t: prepare execution of potentially failing commands for `set -e`
t: prepare `test_when_finished ()`/`test_atexit()` for `set -e`
t0008: silence error in subshell when using `grep -v`
t1301: don't fail in case setfacl(1) doesn't exist or fails
t6002: fix use of `expr` with `set -e`
t9902: fix use of `read` with `set -e`
t: detect errors outside of test casest/lib-git-daemon.sh | 13 ++++++++++--- t/lib-git-svn.sh | 3 +-- t/lib-httpd.sh | 3 +-- t/t0005-signals.sh | 4 ++-- t/t0008-ignores.sh | 4 ++-- t/t1301-shared-repo.sh | 2 +- t/t3600-rm.sh | 2 +- t/t4032-diff-inter-hunk-context.sh | 14 ++++++++------ t/t6002-rev-list-bisect.sh | 17 ++++++++++------- t/t7450-bad-git-dotfiles.sh | 24 +++++++++++++----------- t/t7508-status.sh | 4 ++-- t/t9138-git-svn-authors-prog.sh | 4 ++-- t/t9200-git-cvsexportcommit.sh | 3 +-- t/t9400-git-cvsserver-server.sh | 5 +++-- t/t9401-git-cvsserver-crlf.sh | 4 ++-- t/t9402-git-cvsserver-refs.sh | 4 ++-- t/t9902-completion.sh | 2 +- t/test-lib-functions.sh | 12 ++++++++---- t/test-lib.sh | 8 ++++++-- 19 files changed, 76 insertions(+), 56 deletions(-)
--- base-commit: 8c9303b1ffae5b745d1b0a1f98330cf7944d8db0 change-id: 20260410-b4-pks-tests-with-set-e-3ae479b24b51