git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/6] reftable: some more portability improvements

From
Patrick Steinhardt <ps@pks.im>
Date
Mar 31, 2026, 11:26 UTC
Message-ID
<20260331-pks-reftable-portability-fixes-v1-0-46bfae55c68c@pks.im>
Hi,

this patch series contains the last set of portability improvements that currently sits in the reftable implementation of libgit2. With these patches merged lbigit2 is able to fully reuse the reftable library while only having to provide its own system headers.

I've got a test run with libgit2 at [1], the code in Git is tested at [2]. Overall we're quite close -- the pull requests to implement the repository extension and to adjust handling of pseudo-refs have been merged. Still missing is a couple of test fixes, but once those are merged the reftable backend itself will be in review.

Thanks!
Patrick

[1]: https://github.com/libgit2/libgit2/pull/7117 [2]: https://gitlab.com/gitlab-org/git/-/merge_requests/535

---
Patrick Steinhardt (6):
      reftable/system: provide `REFTABLE_INLINE()` macro
      reftable/stack: don't call fsync(3p) unless provided
      reftable/fsck: use REFTABLE_UNUSED instead of UNUSED
      reftable/system: add abstraction to retrieve time in milliseconds
      reftable/system: add abstraction to mmap files
      reftable: introduce "reftable-system.h" header
 reftable/basics.h               | 20 ++++++++++----------
 reftable/blocksource.c          | 19 +++++++------------
 reftable/fsck.c                 |  2 +-
 reftable/pq.h                   |  4 ++--
 reftable/record.h               |  4 ++--
 reftable/reftable-basics.h      |  2 +-
 reftable/reftable-block.h       |  3 +--
 reftable/reftable-blocksource.h |  2 +-
 reftable/reftable-error.h       |  2 ++
 reftable/reftable-fsck.h        |  1 +
 reftable/reftable-iterator.h    |  1 +
 reftable/reftable-merged.h      |  1 +
 reftable/reftable-record.h      |  2 +-
 reftable/reftable-stack.h       |  1 +
 reftable/reftable-system.h      |  7 +++++++
 reftable/reftable-table.h       |  1 +
 reftable/reftable-writer.h      |  4 +---
 reftable/stack.c                | 29 +++++------------------------
 reftable/system.c               | 26 ++++++++++++++++++++++++++
 reftable/system.h               | 26 ++++++++++++++++++++++++--
 20 files changed, 96 insertions(+), 61 deletions(-)

--- base-commit: 270e10ad6dda3379ea0da7efd11e4fbf2cd7a325 change-id: 20260330-pks-reftable-portability-fixes-36ebf9f227c2

Next: Patrick Steinhardt
Message 1 of 28 in “reftable: some more portability improvements”
  1. 0/6 reftable: some more portability improvementsPatrick Steinhardt, Mar 31, 2026
  2. 1/6 reftable/system: provide `REFTABLE_INLINE()` macroPatrick Steinhardt, Mar 31, 2026
  3. Junio C HamanoMar 31, 2026
  4. René ScharfeMar 31, 2026
  5. Junio C HamanoMar 31, 2026
  6. René ScharfeMar 31, 2026
  7. brian m. carlsonMar 31, 2026
  8. Patrick SteinhardtApr 1, 2026
  9. 2/6 reftable/stack: don't call fsync(3p) unless providedPatrick Steinhardt, Mar 31, 2026
  10. Junio C HamanoMar 31, 2026
  11. Patrick SteinhardtApr 1, 2026
  12. 3/6 reftable/fsck: use REFTABLE_UNUSED instead of UNUSEDPatrick Steinhardt, Mar 31, 2026
  13. Junio C HamanoMar 31, 2026
  14. 4/6 reftable/system: add abstraction to retrieve time in millisecondsPatrick Steinhardt, Mar 31, 2026
  15. 5/6 reftable/system: add abstraction to mmap filesPatrick Steinhardt, Mar 31, 2026
  16. 6/6 reftable: introduce "reftable-system.h" headerPatrick Steinhardt, Mar 31, 2026
  17. Junio C HamanoMar 31, 2026
  18. Patrick SteinhardtApr 1, 2026
  19. Junio C HamanoApr 1, 2026
  20. Patrick SteinhardtApr 2, 2026
  21. 0/5 reftable: some more portability improvementsPatrick Steinhardt, Apr 2, 2026
  22. 1/5 reftable: introduce "reftable-system.h" headerPatrick Steinhardt, Apr 2, 2026
  23. 2/5 reftable/stack: provide fsync(3p) via system headerPatrick Steinhardt, Apr 2, 2026
  24. Junio C HamanoApr 2, 2026
  25. 3/5 reftable/fsck: use REFTABLE_UNUSED instead of UNUSEDPatrick Steinhardt, Apr 2, 2026
  26. 4/5 reftable/system: add abstraction to retrieve time in millisecondsPatrick Steinhardt, Apr 2, 2026
  27. Junio C HamanoApr 2, 2026
  28. 5/5 reftable/system: add abstraction to mmap filesPatrick Steinhardt, Apr 2, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.