[PATCH v2 07/12] builtin/fsck: stop using `the_repository` when checking refs
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Mar 23, 2026, 15:02 UTC
- Message-ID
- <20260323-b4-pks-fsck-without-the-repository-v2-7-e8dc79bca651@pks.im>
- In-Reply-To
- <20260323-b4-pks-fsck-without-the-repository-v2-0-e8dc79bca651@pks.im>
We implicitly rely on `the_repository` when checking refs. Refactor this to instead inject the repository via the callback payload.
Signed-off-by: Patrick Steinhardt <ps@pks.im> --- builtin/fsck.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/builtin/fsck.c b/builtin/fsck.c index edbff16add..efc60862ae 100644 --- a/builtin/fsck.c +++ b/builtin/fsck.c @@ -574,11 +574,12 @@ static int snapshot_ref(const struct reference *ref, void *cb_data) return 0; } -static int fsck_handle_ref(const struct reference *ref, void *cb_data UNUSED) +static int fsck_handle_ref(const struct reference *ref, void *cb_data) { + struct repository *repo = cb_data; struct object *obj; - obj = parse_object(the_repository, ref->oid); + obj = parse_object(repo, ref->oid); obj->flags |= USED; fsck_put_object_name(&fsck_walk_options, ref->oid, "%s", ref->name); @@ -665,7 +666,7 @@ static void free_snapshot_refs(struct snapshot *snap) free(snap->ref); } -static void process_refs(struct snapshot *snap) +static void process_refs(struct repository *repo, struct snapshot *snap) { struct worktree **worktrees, **p; @@ -674,7 +675,7 @@ static void process_refs(struct snapshot *snap) .name = snap->ref[i].refname, .oid = &snap->ref[i].oid, }; - fsck_handle_ref(&ref, NULL); + fsck_handle_ref(&ref, repo); } if (include_reflogs) { @@ -1095,7 +1096,7 @@ int cmd_fsck(int argc, } /* Process the snapshotted refs and the reflogs. */ - process_refs(&snap); + process_refs(repo, &snap); /* If not given any explicit objects, process index files too. */ if (!argc)
-- 2.53.0.1118.gaef5881109.dirty