Re: [PATCH v2] t0410: modernize delete_object helper
- From
Jeff King <peff@peff.net>
- Date
- Mar 18, 2026, 02:37 UTC
- Message-ID
- <20260318023757.GA1925517@coredump.intra.peff.net>
- In-Reply-To
- <xmqq3423928q.fsf@gitster.g>
On Fri, Mar 13, 2026 at 08:29:41AM -0700, Junio C Hamano wrote:
Show 7 quoted lines
> I am tempted to add this to SubmittingPatches::[test]; the first > line of the new paragraph appears several lines before the pre- > context but without "`make test` from the top-level". > [...] > +After any code change, make sure that the entire test suite passes, > +with `make test` from the top-level. We say this twice here because > +it is important.
Seems reasonable. The other mention of "run the whole suite" is buried inside a big paragraph.
I have no idea if people read the document at all, though. I certainly don't, but I am also not a new person trying to join the project. I've usually read, if not participated in, most discussions which lead to changes in them anyway. ;)
-Peff