git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Signed-off-by: aum2357 <ahambrahmasmi2357@gmail.com>

From
Aaum2357 <ahambrahmasmi2357@gmail.com>
Date
Mar 13, 2026, 13:58 UTC
Message-ID
<20260313135836.563264-1-ahambrahmasmi2357@gmail.com>
diff: use conventional comparison order
Replace `0 <= addremove_explicit` with `addremove_explicit >= 0`
to follow the common coding style where variables appear on the
left side of comparisons.
---
 builtin/add.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/add.c b/builtin/add.c
index 0ee21692c2..ad0d6047af 100644
--- a/builtin/add.c
+++ b/builtin/add.c
@@ -432,7 +432,7 @@ int cmd_add(int argc,
 	argc--;
 	argv++;
 
-	if (0 <= addremove_explicit)
+	if ( addremove_explicit >= 0 )
 		addremove = addremove_explicit;
 	else if (take_worktree_changes && ADDREMOVE_DEFAULT)
 		addremove = 0; /* "-u" was given but not "-A" */
-- 
2.53.0
Message 1 of 1 in “Signed-off-by: aum2357 <ahambrahmasmi2357@gmail.com>”
  1. Signed-off-by: aum2357 <ahambrahmasmi2357@gmail.com>aum2357, Mar 13, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.