[PATCH v1 0/2] avoid unnecessary strbuf_split*() and strbuf-by-value usage
- From
Deveshi Dwivedi <deveshigurgaon@gmail.com>
- Date
- Mar 8, 2026, 18:03 UTC
- Message-ID
- <20260308180359.31188-1-deveshigurgaon@gmail.com>
Junio's "do not overuse strbuf_split*()" series [1] calls out remaining uses of strbuf_split*() as leftover bits for others to continue. This series picks up two of them.
write_worktree_linking_files() takes two struct strbuf parameters by value even though it only needs plain path strings. This is the same class of problem fixed for builtin/clean.c in that series.
parse_combine_filter() in list-objects-filter-options.c uses strbuf_split_str() to split a combine: filter spec at '+', then mutates each non-final piece to strip the trailing delimiter. An array of strbufs is unnecessary; the function processes one sub-spec at a time and does not use strbuf editing on the pieces.
[1]: https://lore.kernel.org/git/20250731225433.4028872-1-gitster@pobox.com/
Deveshi Dwivedi (2): worktree: do not pass strbuf by value list-objects-filter-options: avoid strbuf_split_str()
builtin/worktree.c | 2 +- list-objects-filter-options.c | 40 +++++++++++++++++------------------ worktree.c | 22 +++++++++---------- worktree.h | 2 +- 4 files changed, 33 insertions(+), 33 deletions(-)
-- 2.52.0.230.gd8af7cadaa