[PATCH] fetch: fix wrong evaluation order in URL trailing-slash trimming
if i == -1, url[i] will be UB.
Signed-off-by: cuiweixie <cuiweixie@gmail.com>
---
builtin/fetch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/fetch.c b/builtin/fetch.c
index a3bc7e9380..306138c6e5 100644
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -722,7 +722,7 @@ static void display_state_init(struct display_state *display_state, struct ref *
display_state->url = xstrdup("foreign");
display_state->url_len = strlen(display_state->url);
- for (i = display_state->url_len - 1; display_state->url[i] == '/' && 0 <= i; i--)
+ for (i = display_state->url_len - 1; 0 <= i && display_state->url[i] == '/'; i--)
;
display_state->url_len = i + 1;
if (4 < i && !strncmp(".git", display_state->url + i - 3, 4))
--
2.39.5 (Apple Git-154)