git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] format-patch: make format.noprefix a boolean

From
Jeff King <peff@peff.net>
Date
Feb 20, 2026, 12:28 UTC
Message-ID
<20260220122859.GA612853@coredump.intra.peff.net>
In-Reply-To
<format.noprefix_boolean.39d@msgid.xyz>
On Wed, Feb 18, 2026 at 09:26:17PM +0100, kristofferhaugsbakk@fastmail.com wrote:
Show 16 quoted lines
> This is a breaking change. And as far as breaking changes go it is
> pretty benign:
> 
> • The documentation claims that this config is equivalent to
>   `diff.noprefix`; this is just a bug fix if the documentation is
>   what defines the application interface
> • Only users with non-boolean values will run into problems when we
>   try to parse it as a boolean. But what would (1) make them suspect
>   they could do that in the first place, and (2) have motivated them to
>   do it?
> • Users who have set this to `false` and expect that to mean *enable
>   format.noprefix* (current behavior) will now have the opposite
>   experience. Which is not a reasonable setup.
> 
> Let’s only offer a breaking change fig leaf by hinting about the
> previous behavior before dying.

Thanks for following through with this. I probably would not have bothered with even the fig leaf, and just considered it a bug fix. But since you bothered to write it, I don't object.

-Peff
Previous: Kristoffer HaugsbakkNext: kristofferhaugsbakk@fastmail.com
Message 5 of 16 in “format-patch: make boolean and mention in diff-options.adoc”
  1. 0/2 format-patch: make boolean and mention in diff-options.adockristofferhaugsbakk@fastmail.com, Feb 18, 2026
  2. 1/2 format-patch: make format.noprefix a booleankristofferhaugsbakk@fastmail.com, Feb 18, 2026
  3. Junio C HamanoFeb 19, 2026
  4. Kristoffer HaugsbakkFeb 23, 2026
  5. Jeff KingFeb 20, 2026
  6. 2/2 doc: diff-options.adoc: show format.noprefix for format-patchkristofferhaugsbakk@fastmail.com, Feb 18, 2026
  7. Junio C HamanoFeb 19, 2026
  8. 0/2 format-patch: make boolean and mention in diff-options.adockristofferhaugsbakk@fastmail.com, Feb 23, 2026
  9. 1/2 format-patch: make format.noprefix a booleankristofferhaugsbakk@fastmail.com, Feb 23, 2026
  10. 2/2 doc: diff-options.adoc: show format.noprefix for format-patchkristofferhaugsbakk@fastmail.com, Feb 23, 2026
  11. Jean-Noël AvilaFeb 27, 2026
  12. Junio C HamanoFeb 27, 2026
  13. kristofferhaugsbakk@fastmail.comFeb 28, 2026
  14. Jean-Noël AVILAFeb 28, 2026
  15. doc: diff-options.adoc: make *.noprefix split translatablekristofferhaugsbakk@fastmail.com, Mar 1, 2026
  16. Junio C HamanoMar 2, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.