[GSOC PATCH v2] t7003: modernize path existence checks using test helpers
- From
SoutrikDas <valusoutrik@gmail.com>
- Date
- Feb 10, 2026, 18:41 UTC
- Message-ID
- <20260210184156.50363-1-valusoutrik@gmail.com>
- In-Reply-To
- <20260210181445.49380-1-valusoutrik@gmail.com>
Replace 'test -f' and 'test -d' with Git's path helpers. Strengthen the '! test -d dir' and '! test -d diroh/dir' tests.
Checking the test setup before test 12 confirms that there are no expected non directories named 'dir' or 'diroh/dir'
Signed-off-by: SoutrikDas <valusoutrik@gmail.com> --- v2: Address feedback from Junio C Hamano Acknowledge that the rewritten tests are stricter --- t/t7003-filter-branch.sh | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/t/t7003-filter-branch.sh b/t/t7003-filter-branch.sh index 5ab4d41ee7..c475769858 100755 --- a/t/t7003-filter-branch.sh +++ b/t/t7003-filter-branch.sh @@ -92,8 +92,8 @@ test_expect_success 'rewrite, renaming a specific file' ' test_expect_success 'test that the file was renamed' ' test D = "$(git show HEAD:doh --)" && - ! test -f D.t && - test -f doh && + test_path_is_missing D.t && + test_path_is_file doh && test D = "$(cat doh)" ' @@ -103,10 +103,10 @@ test_expect_success 'rewrite, renaming a specific directory' ' test_expect_success 'test that the directory was renamed' ' test dir/D = "$(git show HEAD:diroh/D.t --)" && - ! test -d dir && - test -d diroh && - ! test -d diroh/dir && - test -f diroh/D.t && + test_path_is_missing dir && + test_path_is_dir diroh && + test_path_is_missing diroh/dir && + test_path_is_file diroh/D.t && test dir/D = "$(cat diroh/D.t)" '
-- 2.52.0