Re: [PATCH 0/3] commit-msg.sample: reject messages that would confuse "git am"

From: Jeff King <peff@peff.net>
Date: Feb 10, 2026, 06:46 UTC
Message-ID: <20260210064608.GB1756549@coredump.intra.peff.net>
In-Reply-To: <f5f100de-815e-4bf3-832f-3d473413c635@gmail.com>

On Mon, Feb 09, 2026 at 10:43:23AM +0000, Phillip Wood wrote:

Show 9 quoted lines

> >    2. I'd guess that these days only a small minority of people care
> >       about sending patches by email. So for most people, a warning about
> >       their commit message containing a diff or "---" will be mostly
> >       useless, if not outright confusing.
> 
> People do download patches from github and apply them even if they're not
> using a email based workflow. I'm not entirely clear but I think that's what
> happened in the post Matthias linked to. Though if they're using "patch"
> rather than "git am" to apply them indenting the diff wont help.

Yeah, true. I have done that (thought not very often). I think limiting our thinking to "git am" in that case is probably OK. We have to draw the line somewhere.

-Peff