git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/5] ci: make test slicing consistent across Meson/Make

From
Patrick Steinhardt <ps@pks.im>
Date
Feb 9, 2026, 16:56 UTC
Message-ID
<20260209-b4-pks-ci-meson-improvements-v1-3-38444dec4874@pks.im>
In-Reply-To
<20260209-b4-pks-ci-meson-improvements-v1-0-38444dec4874@pks.im>

In the preceding commit we have adjusted test slicing to be one-based when using the "ci/run-test-slice.sh" script. But we also have an equivalent script for Meson that is still zero-based, which is of course inconsistent.

Adapt the script to be one-based, as well, and adapt the GitHub workflow accordingly. Note that GitLab doesn't yet use the script, so it does not need to be adapted. This will change in the next commit though.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
---
 .github/workflows/main.yml | 2 +-
 ci/run-test-slice-meson.sh | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 2b175dc5c6..1b7a16e1f1 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -298,7 +298,7 @@ jobs:
         path: build
     - name: Test
       shell: pwsh
-      run: ci/run-test-slice-meson.sh build ${{matrix.nr}} 10
+      run: ci/run-test-slice-meson.sh build ${{matrix.nr + 1}} 10
     - name: print test failures
       if: failure() && env.FAILED_TEST_ARTIFACTS != ''
       shell: bash
diff --git a/ci/run-test-slice-meson.sh b/ci/run-test-slice-meson.sh
index 961c94fba0..a6df927ba5 100755
--- a/ci/run-test-slice-meson.sh
+++ b/ci/run-test-slice-meson.sh
@@ -9,5 +9,5 @@
 
 group "Run tests" \
 	meson test -C "$1" --no-rebuild --print-errorlogs \
-		--test-args="$GIT_TEST_OPTS" --slice "$((1+$2))/$3" ||
+		--test-args="$GIT_TEST_OPTS" --slice "$(($2))/$3" ||
 handle_failed_tests
-- 
2.53.0.295.g64333814d3.dirty
Previous: Justin ToblerNext: Justin Tobler
Message 5 of 13 in “Some assorted fixes for GitLab CI”
  1. 0/5 Some assorted fixes for GitLab CIPatrick Steinhardt, Feb 9, 2026
  2. 1/5 ci: handle failures of test-slice helperPatrick Steinhardt, Feb 9, 2026
  3. 2/5 ci: don't skip smallest test slice in GitLabPatrick Steinhardt, Feb 9, 2026
  4. Justin ToblerFeb 9, 2026
  5. 3/5 ci: make test slicing consistent across Meson/MakePatrick Steinhardt, Feb 9, 2026
  6. Justin ToblerFeb 9, 2026
  7. Patrick SteinhardtFeb 10, 2026
  8. Junio C HamanoFeb 10, 2026
  9. Jeff KingFeb 10, 2026
  10. Patrick SteinhardtFeb 11, 2026
  11. 4/5 gitlab-ci: use "run-test-slice-meson.sh"Patrick Steinhardt, Feb 9, 2026
  12. 5/5 gitlab-ci: handle failed tests on MSVC+Meson jobPatrick Steinhardt, Feb 9, 2026
  13. Justin ToblerFeb 9, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.