Re: [PATCH v2] meson: wire up gitk and git-gui

From: Jeff King <peff@peff.net>
Date: Feb 5, 2026, 09:37 UTC
Message-ID: <20260205093748.GA2177239@coredump.intra.peff.net>
In-Reply-To: <20260204-b4-pks-meson-tcl-tk-v2-1-5bc3ccf3a8ce@pks.im>

On Wed, Feb 04, 2026 at 09:38:11AM +0100, Patrick Steinhardt wrote:

Show 6 quoted lines

> Wire up both gitk and git-gui in Meson as subprojects. These two
> programs should be the last missing pieces for feature compatibility
> with our Makefile for distributors.
> 
> Note that Meson expects subprojects to live in the "subprojects/"
> directory. Create symlinks to fulfill this requirement.

The GitHub Actions win+Meson job fails for 'jch' with:

  Project name: gitk
  Project version: undefined
  Program sh found: YES (C:\Program Files\Git\bin\sh.EXE)
  Program wish found: YES (C:\Program Files\Git\mingw64\bin\wish.EXE)
  Program chmod found: YES (C:\Program Files\Git\usr\bin\chmod.EXE)
  Program mv found: YES (C:\Program Files\Git\usr\bin\mv.EXE)
  Program sed found: YES (C:\Program Files\Git\usr\bin\sed.EXE)
  Program msgfmt found: NO

  subprojects\gitk\meson.build:28:3: ERROR: Program 'msgfmt' not found or not executable

I didn't investigate, but presumably it is related to this topic.

-Peff