git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] [GSoC][PATCH] t9160: modernize test path checking

From
Pushkar Singh <pushkarkumarsingh1970@gmail.com>
Date
Feb 2, 2026, 13:46 UTC
Message-ID
<20260202134657.15320-1-pushkarkumarsingh1970@gmail.com>
In-Reply-To
<CAAGT0iKRA++yUcCxyRLZN14jLV0xNVSXcKr=F5vJ48dXVEn6PQ@mail.gmail.com>
Hi Hoda,
Welcome!
I took a quick look. The replacements with test_path_is_file, test_path_is_dir, and test_file_not_empty look appropriate here, and the patch itself seems straightforward.
Minor nits:
- I noticed "subsqeuent" is misspelled in a couple of the existing test descriptions (not introduced by this patch, but might be a nice follow-up cleanup).
- You might also consider dropping the duplicated [PATCH] tag in the subject for cleanliness.
Otherwise, this looks like a reasonable microproject.

Best, Pushkar

Previous: Hoda Salim
Message 2 of 2 in “Re: [PATCH] [GSoC][PATCH] t9160:modernize test path checking”
  1. Hoda SalimFeb 2, 2026
  2. Pushkar SinghFeb 2, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.