[PATCH 2/4] remote: drop const return of tracking_for_push_dest()
- From
Jeff King <peff@peff.net>
- Date
- Jan 19, 2026, 05:20 UTC
- Message-ID
- <20260119052026.GB1991523@coredump.intra.peff.net>
- In-Reply-To
- <20260119051858.GA1991308@coredump.intra.peff.net>
The string returned from tracking_for_push_dest() comes from apply_refspec(), and thus is always an allocated string (or NULL). We should return a non-const pointer so that the caller knows that ownership of the string is being transferred.
This goes back to the function's origin in e291c75a95 (remote.c: add branch_get_push, 2015-05-21). It never really mattered because our return is just forwarded through branch_get_push_1(), which returns a const string as part of an intentionally hacky memory management scheme (see that commit for details).
As the first step of untangling that hackery, let's drop the extra const from this helper function (and from the variables that store its result). There should be no functional change (yet).
Signed-off-by: Jeff King <peff@peff.net> --- remote.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/remote.c b/remote.c index 3dc100be83..5de9619bc7 100644 --- a/remote.c +++ b/remote.c @@ -1869,9 +1869,9 @@ const char *branch_get_upstream(struct branch *branch, struct strbuf *err) return branch->merge[0]->dst; } -static const char *tracking_for_push_dest(struct remote *remote, - const char *refname, - struct strbuf *err) +static char *tracking_for_push_dest(struct remote *remote, + const char *refname, + struct strbuf *err) { char *ret; @@ -1899,7 +1899,7 @@ static const char *branch_get_push_1(struct repository *repo, if (remote->push.nr) { char *dst; - const char *ret; + char *ret; dst = apply_refspecs(&remote->push, branch->refname); if (!dst) @@ -1929,7 +1929,8 @@ static const char *branch_get_push_1(struct repository *repo, case PUSH_DEFAULT_UNSPECIFIED: case PUSH_DEFAULT_SIMPLE: { - const char *up, *cur; + const char *up; + char *cur; up = branch_get_upstream(branch, err); if (!up)
-- 2.53.0.rc0.338.g08aa8a9473