git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[GSoC PATCH v2 1/1] t1420: modernize the lost-found test

From
ACAndrew Chitester <andchi@fastmail.com>
Date
Jan 6, 2026, 13:26 UTC
Message-ID
<20260106132658.798706-1-andchi@fastmail.com>
In-Reply-To
<20260104161536.45384-1-andchi@fastmail.com>

This test indirectly checks that the lost-found folder has 2 files in it and then checks that the expected two files exist. Make this more deliberate by removing the old test -f and compare the actual ls of the lost-found directory with the expected files.

Signed-off-by: Andrew Chitester <andchi@fastmail.com>
---
 t/t1420-lost-found.sh | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/t/t1420-lost-found.sh b/t/t1420-lost-found.sh
index 2fb2f44f02..926c6d63e3 100755
--- a/t/t1420-lost-found.sh
+++ b/t/t1420-lost-found.sh
@@ -28,9 +28,12 @@ test_expect_success 'lost and found something' '
 	test_tick &&
 	git reset --hard HEAD^ &&
 	git fsck --lost-found &&
-	test 2 = $(ls .git/lost-found/*/* | wc -l) &&
-	test -f .git/lost-found/commit/$(cat lost-commit) &&
-	test -f .git/lost-found/other/$(cat lost-other)
+	ls .git/lost-found/*/* >actual &&
+	cat >expect <<-EOF &&
+	.git/lost-found/commit/$(cat lost-commit)
+	.git/lost-found/other/$(cat lost-other)
+	EOF
+	test_cmp expect actual
 '
 
 test_done
-- 
2.52.0
Previous: Andrew Chitester
Message 4 of 4 in “t1420-lost-found.sh: use test_path_is_file for error logging”
  1. t1420-lost-found.sh: use test_path_is_file for error loggingAndrew Chitester, Jan 4, 2026
  2. Junio C HamanoJan 5, 2026
  3. Andrew ChitesterJan 8, 2026
  4. 1/1 t1420: modernize the lost-found testAndrew Chitester, Jan 6, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.