git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t2021: use test helpers instead of shell primitives

From
pushkarkumarsingh1970@gmail.com <pushkarkumarsingh1970@gmail.com>
Date
Jan 2, 2026, 11:03 UTC
Message-ID
<20260102110452.19221-1-pushkarkumarsingh1970@gmail.com>
From: Pushkar Singh <pushkarkumarsingh1970@gmail.com>

The tests here used plain `test -f` and `test -h` checks. Replacing them with `test_path_is_file` and `test_path_is_symlink` makes failures easier to understand and keeps the test style consistent with the rest of the suite.

Signed-off-by: Pushkar Singh <pushkarkumarsingh1970@gmail.com>
---
 t/t2021-checkout-overwrite.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t2021-checkout-overwrite.sh b/t/t2021-checkout-overwrite.sh
index a5c03d5d4a..38c41ae373 100755
--- a/t/t2021-checkout-overwrite.sh
+++ b/t/t2021-checkout-overwrite.sh
@@ -27,7 +27,7 @@ test_expect_success 'checkout commit with dir must not remove untracked a/b' '
 	git rm --cached a/b &&
 	git commit -m "un-track the file" &&
 	test_must_fail git checkout start &&
-	test -f a/b
+	test_path_is_file a/b
 '
 
 test_expect_success 'create a commit where dir a/b changed to symlink' '
@@ -49,7 +49,7 @@ test_expect_success 'checkout commit with dir must not remove untracked a/b' '
 
 test_expect_success SYMLINKS 'the symlink remained' '
 
-	test -h a/b
+	test_path_is_symlink a/b
 '
 
 test_expect_success 'cleanup after previous symlink tests' '
-- 
2.43.0
Message 1 of 1 in “t2021: use test helpers instead of shell primitives”
  1. t2021: use test helpers instead of shell primitivespushkarkumarsingh1970@gmail.com, Jan 2, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.