git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/4] tag: use algo of repo parameter in parse_tag_buffer()

From
René Scharfe <l.s.r@web.de>
Date
Dec 28, 2025, 18:10 UTC
Message-ID
<20251228181051.68724-2-l.s.r@web.de>
In-Reply-To
<20251228181051.68724-1-l.s.r@web.de>

Stop using "the_hash_algo" explicitly and implictly via parse_oid_hex() and instead use the "hash_algo" member of the passed in repository, which is more correct.

Signed-off-by: René Scharfe <l.s.r@web.de>
---
 tag.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tag.c b/tag.c
index f5c232d2f1..dec5ea8eb0 100644
--- a/tag.c
+++ b/tag.c
@@ -148,9 +148,11 @@ int parse_tag_buffer(struct repository *r, struct tag *item, const void *data, u
 		FREE_AND_NULL(item->tag);
 	}
 
-	if (size < the_hash_algo->hexsz + 24)
+	if (size < r->hash_algo->hexsz + 24)
 		return -1;
-	if (memcmp("object ", bufptr, 7) || parse_oid_hex(bufptr + 7, &oid, &bufptr) || *bufptr++ != '\n')
+	if (memcmp("object ", bufptr, 7) ||
+	    parse_oid_hex_algop(bufptr + 7, &oid, &bufptr, r->hash_algo) ||
+	    *bufptr++ != '\n')
 		return -1;
 
 	if (!starts_with(bufptr, "type "))
-- 
2.52.0
Previous: René ScharfeNext: Kristoffer Haugsbakk
Message 5 of 6 in “tag: stop using the_repository”
  1. 0/4 tag: stop using the_repositoryRené Scharfe, Dec 28, 2025
  2. 2/4 tag: support arbitrary repositories in gpg_verify_tag()René Scharfe, Dec 28, 2025
  3. 3/4 tag: support arbitrary repositories in parse_tag()René Scharfe, Dec 28, 2025
  4. 4/4 tag: stop using the_repositoryRené Scharfe, Dec 28, 2025
  5. 1/4 tag: use algo of repo parameter in parse_tag_buffer()René Scharfe, Dec 28, 2025
  6. Kristoffer HaugsbakkDec 30, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.