git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 09/14] commit: add commit_stack_init()

From
René Scharfe <l.s.r@web.de>
Date
Dec 24, 2025, 17:03 UTC
Message-ID
<20251224170327.68049-10-l.s.r@web.de>
In-Reply-To
<20251224170327.68049-1-l.s.r@web.de>

Add a function for initializing a struct commit_stack, for when static initialization is not possible or impractical.

Signed-off-by: René Scharfe <l.s.r@web.de>
---
 commit.c | 10 ++++++++--
 commit.h |  1 +
 2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/commit.c b/commit.c
index f2edafa49c..55b1c8d2f8 100644
--- a/commit.c
+++ b/commit.c
@@ -1982,6 +1982,12 @@ int run_commit_hook(int editor_is_used, const char *index_file,
 	return run_hooks_opt(the_repository, name, &opt);
 }
 
+void commit_stack_init(struct commit_stack *stack)
+{
+	stack->items = NULL;
+	stack->nr = stack->alloc = 0;
+}
+
 void commit_stack_push(struct commit_stack *stack, struct commit *commit)
 {
 	ALLOC_GROW(stack->items, stack->nr + 1, stack->alloc);
@@ -1995,6 +2001,6 @@ struct commit *commit_stack_pop(struct commit_stack *stack)
 
 void commit_stack_clear(struct commit_stack *stack)
 {
-	FREE_AND_NULL(stack->items);
-	stack->nr = stack->alloc = 0;
+	free(stack->items);
+	commit_stack_init(stack);
 }
diff --git a/commit.h b/commit.h
index 81e047f820..7c01a76425 100644
--- a/commit.h
+++ b/commit.h
@@ -387,6 +387,7 @@ struct commit_stack {
 };
 #define COMMIT_STACK_INIT { 0 }
 
+void commit_stack_init(struct commit_stack *);
 void commit_stack_push(struct commit_stack *, struct commit *);
 struct commit *commit_stack_pop(struct commit_stack *);
 void commit_stack_clear(struct commit_stack *);
-- 
2.52.0
Previous: René ScharfeNext: René Scharfe
Message 12 of 15 in “export and use commit_stack”
  1. 00/14 export and use commit_stackRené Scharfe, Dec 24, 2025
  2. 01/14 revision: export commit_stackRené Scharfe, Dec 24, 2025
  3. 05/14 remote: use commit_stack for local_commitsRené Scharfe, Dec 24, 2025
  4. 08/14 test-reach: use commit_stackRené Scharfe, Dec 24, 2025
  5. 04/14 name-rev: use commit_stackRené Scharfe, Dec 24, 2025
  6. 02/14 log: use commit_stackRené Scharfe, Dec 24, 2025
  7. 07/14 remote: use commit_stack for src_commitsRené Scharfe, Dec 24, 2025
  8. 03/14 midx: use commit_stackRené Scharfe, Dec 24, 2025
  9. 06/14 remote: use commit_stack for sent_tipsRené Scharfe, Dec 24, 2025
  10. 11/14 shallow: use commit_stackRené Scharfe, Dec 24, 2025
  11. 10/14 pack-bitmap-write: use commit_stackRené Scharfe, Dec 24, 2025
  12. 09/14 commit: add commit_stack_init()René Scharfe, Dec 24, 2025
  13. 13/14 commit-graph: use commit_stackRené Scharfe, Dec 24, 2025
  14. 14/14 commit-reach: use commit_stackRené Scharfe, Dec 24, 2025
  15. 12/14 commit: add commit_stack_grow()René Scharfe, Dec 24, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.