git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] coccicheck: emit the contents of cocci patch

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 13, 2025, 01:46 UTC
Message-ID
<20251213014628.3380826-2-gitster@pobox.com>
In-Reply-To
<20251213014628.3380826-1-gitster@pobox.com>

Telling the user "you got some error messages" without showing what the errors are is almost useless in CI environment, as the errors cannot be examined without downloading build artifacts.

Arrange it to spew out the output when it fails.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 7ca2118813..0117d0008c 100644
--- a/Makefile
+++ b/Makefile
@@ -3521,7 +3521,7 @@ else
 COCCICHECK_PATCH_MUST_BE_EMPTY_FILES = $(COCCICHECK_PATCHES_INTREE)
 endif
 coccicheck: $(COCCICHECK_PATCH_MUST_BE_EMPTY_FILES)
-	! grep -q ^ $(COCCICHECK_PATCH_MUST_BE_EMPTY_FILES) /dev/null
+	! grep ^ $(COCCICHECK_PATCH_MUST_BE_EMPTY_FILES) /dev/null
 
 # See contrib/coccinelle/README
 coccicheck-pending: coccicheck-test
-- 
2.52.0-357-gead5eaf5b3
Previous: Junio C HamanoNext: Patrick Steinhardt
Message 2 of 4 in “Use MEMZERO_ARRAY() a bit more”
  1. 0/2 Use MEMZERO_ARRAY() a bit moreJunio C Hamano, Dec 13, 2025
  2. 1/2 coccicheck: emit the contents of cocci patchJunio C Hamano, Dec 13, 2025
  3. Patrick SteinhardtDec 15, 2025
  4. 2/2 cocci: use MEMZERO_ARRAY() a bit moreJunio C Hamano, Dec 13, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.