git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] unit-test: ignore --no-chain-lint

From
Jeff King <peff@peff.net>
Date
Nov 18, 2025, 09:32 UTC
Message-ID
<20251118093243.GA530438@coredump.intra.peff.net>
In-Reply-To
<20251118093221.GA530337@coredump.intra.peff.net>

In the same spirit as 9faf3963b6 (t: introduce compatibility options to clar-based tests, 2024-12-13), we should ignore --no-chain-lint passed to our clar tests, since it may appear in GIT_TEST_OPTS to be used with other tests.

This is particularly important on Windows CI, where --no-chain-lint is added to the test options by default, and the meson build will pass all options to the unit tests. The only reason our meson Windows CI job does not run into this currently is that it is not respecting GIT_TEST_OPTS at all! So ignoring this option is a prerequisite to fixing that situation.

Signed-off-by: Jeff King <peff@peff.net>
---
 t/unit-tests/unit-test.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/t/unit-tests/unit-test.c b/t/unit-tests/unit-test.c
index 5af645048a..752fb38fb3 100644
--- a/t/unit-tests/unit-test.c
+++ b/t/unit-tests/unit-test.c
@@ -29,6 +29,7 @@ int cmd_main(int argc, const char **argv)
 		OPT_NOOP_NOARG('d', "debug"),
 		OPT_NOOP_NOARG(0, "github-workflow-markup"),
 		OPT_NOOP_NOARG(0, "no-bin-wrappers"),
+		OPT_NOOP_ARG(0, "no-chain-lint"),
 		OPT_NOOP_ARG(0, "root"),
 		OPT_NOOP_ARG(0, "stress"),
 		OPT_NOOP_NOARG(0, "tee"),
-- 
2.52.0.278.gadc6434dc3
Previous: Jeff KingNext: Jeff King
Message 2 of 4 in “meson-windows-test ci output fixes”
  1. 0/2 meson-windows-test ci output fixesJeff King, Nov 18, 2025
  2. 1/2 unit-test: ignore --no-chain-lintJeff King, Nov 18, 2025
  3. 2/2 ci(windows-meson-test): handle options and output like other test jobsJeff King, Nov 18, 2025
  4. Johannes SchindelinNov 25, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.