Re: t7528-signed-commit-ssh.sh fails due to ssh-agent fails to start with ENAMETOOLONG
- From
Jeff King <peff@peff.net>
- Date
- Oct 17, 2025, 10:54 UTC
- Message-ID
- <20251017105400.GB1015973@coredump.intra.peff.net>
- In-Reply-To
- <aPIR8fB4w5Jkeiq2@mail.hacktheplanet.fi>
On Fri, Oct 17, 2025 at 06:52:49PM +0900, Lauri Tirkkonen wrote:
Show 9 quoted lines
> > If I unset SSH_AUTH_SOCK in my environment, then the test consistently > > fails. But I'm somewhat amazed that nobody has complained about this > > before. Surely somebody somewhere (especially CI!) is running t7528 > > without SSH_AUTH_SOCK set in the environment. Which makes wonder if I'm > > missing something. > > I believe the issue surfaced only now because prior to OpenSSH 10.1, > ssh-agent would put its socket in /tmp by default, not under $HOME. See > https://www.openssh.com/txt/release-10.1
Ah, of course. That explains it perfectly, thanks. So we're going to get lots more reports as people upgrade. :)
> We saw this failure in CI on Alpine Linux and worked around by adding -T > to the ssh-agent invocation in this test, but I suppose that won't work > for earlier releases of OpenSSH.
Yeah. We could either do something like "ssh-agent -T || ssh-agent", or we could go with "ssh-agent -a" (which has been around since 2002, but does raise the potential relative-path issue).
-Peff