git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] [Outreachy] commit.c: clarify comment describing commit re-parse behavior

From
Jeff King <peff@peff.net>
Date
Oct 14, 2025, 00:35 UTC
Message-ID
<20251014003508.GD1507@coredump.intra.peff.net>
In-Reply-To
<20251011093611.62937-1-okhuomonajayi54@gmail.com>
On Sat, Oct 11, 2025 at 10:36:11AM +0100, Okhuomon Ajayi wrote:
Show 8 quoted lines
> The existing comment in `parse_commit_buffer()` mentioned a "leftover
> from an earlier failed parse", which could be confusing to new readers.
> It implied an error state rather than the intended cleanup before
> re-parsing a commit.
> 
> Clarifying the comment makes it explicit that we reset the parent list
> to ensure a clean state before re-parsing, which improves readability
> and avoids misunderstanding during future maintenance.

As the original author of this comment, I think what you've written retains the intent but is easier to understand. So looks good to me.

-Peff
Previous: Christian CouderNext: Okhuomon Ajayi
Message 3 of 4 in “[Outreachy] commit.c: clarify comment describing commit re-parse behavior”
  1. [Outreachy] commit.c: clarify comment describing commit re-parse behaviorOkhuomon Ajayi, Oct 11, 2025
  2. Christian CouderOct 13, 2025
  3. Jeff KingOct 14, 2025
  4. Okhuomon AjayiOct 14, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.