git/list[1] front-page[2] threads[3] people[4] search[5] about
wed 2026-10-07 16:58 UTC

[PATCH] [Outreachy] patch-ids: fix const correctness

From
OAOkhuomon Ajayi <okhuomonajayi54@gmail.com>
Date
Oct 9, 2025, 21:57 UTC
Message-ID
<20251009215737.1196464-1-okhuomonajayi54@gmail.com>
In-Reply-To
<20251009214445.1190274-1-okhuomonajayi54@gmail.com>
Fix const correctness warning in patch_id_neq() in patch-ids.c.
Changes in v2:
- Removed NEEDSWORK comment
---
 patch-ids.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/patch-ids.c b/patch-ids.c
index a5683b462c..b6b808332f 100644
--- a/patch-ids.c
+++ b/patch-ids.c
@@ -41,8 +41,8 @@ static int patch_id_neq(const void *cmpfn_data,
 			const struct hashmap_entry *entry_or_key,
 			const void *keydata UNUSED)
 {
-	/* NEEDSWORK: const correctness? */
-	struct diff_options *opt = (void *)cmpfn_data;
+	
+	const struct diff_options *opt = (void *)cmpfn_data;
 	struct patch_id *a, *b;
 
 	a = container_of(eptr, struct patch_id, ent);
-- 
2.43.0
Previous: Kristoffer HaugsbakkNext: Agatha Isabelle
Message 3 of 6 in “[Outreachy] patch-ids: fix const correctness”
  1. [Outreachy] patch-ids: fix const correctnessOkhuomon Ajayi, Oct 9, 2025
  2. Kristoffer HaugsbakkOct 9, 2025
  3. [Outreachy] patch-ids: fix const correctnessOkhuomon Ajayi, Oct 9, 2025
  4. Agatha IsabelleOct 9, 2025
  5. Okhuomon AjayiOct 10, 2025
  6. Junio C HamanoOct 10, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.