[PATCH v2 1/6] ci: deduplicate calls to `apt-get update`
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Oct 8, 2025, 06:27 UTC
- Message-ID
- <20251008-b4-pks-ci-rust-v2-1-d556ee83c381@pks.im>
- In-Reply-To
- <20251008-b4-pks-ci-rust-v2-0-d556ee83c381@pks.im>
When installing dependencies we first check for the distribution that is in use and then we check for the specific job. In the first step we already install all dependencies required to build and test Git, whereas the second step installs a couple of additional dependencies that are only required to perform job-specific tasks.
In both steps we use `apt-get update` to update our repository sources. This is unnecessary though: all platforms that use Aptitude would have already executed this command in the distro-specific step anyway.
Drop the redundant calls.
Signed-off-by: Patrick Steinhardt <ps@pks.im> --- ci/install-dependencies.sh | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh index 0d3aa496fc..645d035250 100755 --- a/ci/install-dependencies.sh +++ b/ci/install-dependencies.sh @@ -120,21 +120,17 @@ esac case "$jobname" in ClangFormat) - sudo apt-get -q update sudo apt-get -q -y install clang-format ;; StaticAnalysis) - sudo apt-get -q update sudo apt-get -q -y install coccinelle libcurl4-openssl-dev libssl-dev \ libexpat-dev gettext make ;; sparse) - sudo apt-get -q update -q sudo apt-get -q -y install libssl-dev libcurl4-openssl-dev \ libexpat-dev gettext zlib1g-dev sparse ;; Documentation) - sudo apt-get -q update sudo apt-get -q -y install asciidoc xmlto docbook-xsl-ns make test -n "$ALREADY_HAVE_ASCIIDOCTOR" ||
-- 2.51.0.764.g787ff6f08a.dirty