Re: [PATCH 0/13] unraveling the mysteries of color variables

From: Jeff King <peff@peff.net>
Date: Sep 16, 2025, 20:28 UTC
Message-ID: <20250916202832.GA613002@coredump.intra.peff.net>
In-Reply-To: <20250916201036.GA612463@coredump.intra.peff.net>

On Tue, Sep 16, 2025 at 04:10:37PM -0400, Jeff King wrote:

> The good news is that my digging did uncover two minor bugs, which are
> fixed here in patches 2 and 3. And the series should improve the
> readability of the code by using named constants and appropriate types
> more consistently.

Either counting is hard, or my brain is fried from looking at this color code. At any rate, the fixes are in patches 3 and 5:

>   [03/13]: grep: don't treat grep_opt.color as a strict bool
>   [05/13]: diff: don't use diff_options.use_color as a strict bool

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.