git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5] alloc: fix dangling pointer in alloc_state cleanup

From
Jeff King <peff@peff.net>
Date
Sep 5, 2025, 13:15 UTC
Message-ID
<20250905131513.GB596956@coredump.intra.peff.net>
In-Reply-To
<xmqqjz2d7t2q.fsf@gitster.g>
On Thu, Sep 04, 2025 at 03:26:21PM -0700, Junio C Hamano wrote:
Show 19 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > It's probably not worth going back and forth on this too much, but I
> > thought the happy medium was:
> >
> >   if (!s)
> > 	return;
> >
> > That is, it is perfectly reasonable and friendly for it to be a noop to
> > free-and-null a NULL value (either never initialized, or already freed).
> > The overkill was worrying about whether somebody passed in a NULL
> > double-pointer. I.e., doing:
> >
> >   alloc_state_free_and_null(&foo);
> >
> > is reasonable and should be idempotent
> 
> ... when foo == NULL, e.g., after alloc_state_free_and_null(&foo)
> has just successfully returned?
Exactly.
> I can by that argument with the reasoning in the updated log message
> below.  Does it good to everybody?
Yep, it looks good to me.
-Peff
Previous: ノウラ | FlareNext: ノウラ | Flare via GitGitGadget
Message 26 of 28 in “reset slab_alloc and state fields in clear_alloc_state()”
  1. reset slab_alloc and state fields in clear_alloc_state()ノウラ | Flare via GitGitGadget, Aug 26, 2025
  2. Junio C HamanoAug 27, 2025
  3. alloc: fix dangling pointer in alloc_state cleanupノウラ | Flare via GitGitGadget, Aug 27, 2025
  4. Torsten BögershausenAug 28, 2025
  5. Junio C HamanoAug 28, 2025
  6. Junio C HamanoAug 28, 2025
  7. alloc: fix dangling pointer in alloc_state cleanupノウラ | Flare via GitGitGadget, Aug 29, 2025
  8. Jeff KingSep 3, 2025
  9. Junio C HamanoSep 3, 2025
  10. alloc: fix dangling pointer in alloc_state cleanupノウラ | Flare via GitGitGadget, Sep 3, 2025
  11. Junio C HamanoSep 4, 2025
  12. ノウラ | FlareSep 4, 2025
  13. Junio C HamanoSep 4, 2025
  14. alloc: fix dangling pointer in alloc_state cleanupノウラ | Flare via GitGitGadget, Sep 4, 2025
  15. Junio C HamanoSep 4, 2025
  16. Jeff KingSep 4, 2025
  17. Junio C HamanoSep 4, 2025
  18. ノウラ | FlareSep 5, 2025
  19. Jeff KingSep 5, 2025
  20. ノウラ | FlareSep 5, 2025
  21. ノウラ | FlareSep 5, 2025
  22. ノウラ | FlareSep 5, 2025
  23. ノウラ | FlareSep 5, 2025
  24. Junio C HamanoSep 5, 2025
  25. ノウラ | FlareSep 5, 2025
  26. Jeff KingSep 5, 2025
  27. alloc: fix dangling pointer in alloc_state cleanupノウラ | Flare via GitGitGadget, Sep 5, 2025
  28. Junio C HamanoSep 5, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.