Re: What's cooking in git.git (Aug 2025, #12; Fri, 29)

From: Jeff King <peff@peff.net>
Date: Sep 2, 2025, 12:39 UTC
Message-ID: <20250902123936.GB711442@coredump.intra.peff.net>
In-Reply-To: <fdee7ee5-21ef-4c5e-92e7-eb92fe07251e@web.de>

On Sun, Aug 31, 2025 at 07:29:30PM +0200, René Scharfe wrote:

Show 14 quoted lines

> On 8/29/25 11:37 PM, Junio C Hamano wrote:
> > * rs/describe-with-lazy-queue-and-khash (2025-08-24) 1 commit
> >  - describe: use khash in finish_depth_computation()
> > 
> >  Instead of scanning for the remaining items to see if there are
> >  still commits to be explored in the queue, use khash to remember
> >  which items are still on the queue (an unacceptable alternative is
> >  to reserve one object flag bits).
> > 
> >  Will merge to 'next'?
> >  source: <9110f085-aec0-42e9-9774-b153ece6284f@web.de>
> Please keep it in seen for now -- Peff's proposal to use an oidset
> instead looks promising.  I'll do some more measurements over the next
> few days and report back.

Thanks for digging into it further. I am not terribly opposed to what you sent earlier, and most of my responses were veering pretty far off-topic. But if we can get away with using oidset here for the same performance, I think the simplicity is worth it.

-Peff