git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[GSoC][PATCH 2/2] t: add test for git refs exists subcommand

From
Meet Soni <meetsoni3017@gmail.com>
Date
Aug 21, 2025, 08:52 UTC
Message-ID
<20250821085246.929307-3-meetsoni3017@gmail.com>
In-Reply-To
<20250821085246.929307-1-meetsoni3017@gmail.com>

The new `git refs exists` subcommand must have identical behavior to its predecessor, `git show-ref --exists`. To avoid duplicating the entire test suite, refactor the existing tests into a shareable helper script.

Extract the tests for the `--exists` flag from `t1403-show-ref.sh` into a new `show-ref-exists-tests.sh` helper. The command under test is parameterized using the `$git_show_ref_exists` variable.

Source new helper to both `t1403-show-ref.sh` and the new test file, `t1462-refs-exists.sh`, ensuring both commands are verified against the same comprehensive test suite.

Mentored-by: Patrick Steinhardt <ps@pks.im>
Mentored-by: shejialuo <shejialuo@gmail.com>
Signed-off-by: Meet Soni <meetsoni3017@gmail.com>
---
 t/meson.build              |  3 +-
 t/show-ref-exists-tests.sh | 66 ++++++++++++++++++++++++++++++++++++++
 t/t1403-show-ref.sh        | 66 +-------------------------------------
 t/t1462-refs-exists.sh     | 22 +++++++++++++
 4 files changed, 91 insertions(+), 66 deletions(-)
 create mode 100644 t/show-ref-exists-tests.sh
 create mode 100755 t/t1462-refs-exists.sh
diff --git a/t/meson.build b/t/meson.build
index baeeba2ce6..eed812a9b9 100644
--- a/t/meson.build
+++ b/t/meson.build
@@ -211,6 +211,7 @@ integration_tests = [
   't1451-fsck-buffer.sh',
   't1460-refs-migrate.sh',
   't1461-refs-list.sh',
+  't1462-refs-exists.sh',
   't1500-rev-parse.sh',
   't1501-work-tree.sh',
   't1502-rev-parse-parseopt.sh',
@@ -1219,4 +1220,4 @@ if perl.found() and time.found()
       timeout: 0,
     )
   endforeach
-endif
\ No newline at end of file
+endif
diff --git a/t/show-ref-exists-tests.sh b/t/show-ref-exists-tests.sh
new file mode 100644
index 0000000000..23b941d386
--- /dev/null
+++ b/t/show-ref-exists-tests.sh
@@ -0,0 +1,66 @@
+git_show_ref_exists=${git_show_ref_exists:-git show-ref --exists}
+
+test_expect_success '--exists with existing reference' '
+	${git_show_ref_exists} refs/heads/$GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
+'
+
+test_expect_success '--exists with missing reference' '
+	test_expect_code 2 ${git_show_ref_exists} refs/heads/does-not-exist
+'
+
+test_expect_success '--exists does not use DWIM' '
+	test_expect_code 2 ${git_show_ref_exists} $GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME 2>err &&
+	grep "reference does not exist" err
+'
+
+test_expect_success '--exists with HEAD' '
+	${git_show_ref_exists} HEAD
+'
+
+test_expect_success '--exists with bad reference name' '
+	test_when_finished "git update-ref -d refs/heads/bad...name" &&
+	new_oid=$(git rev-parse HEAD) &&
+	test-tool ref-store main update-ref msg refs/heads/bad...name $new_oid $ZERO_OID REF_SKIP_REFNAME_VERIFICATION &&
+	${git_show_ref_exists} refs/heads/bad...name
+'
+
+test_expect_success '--exists with arbitrary symref' '
+	test_when_finished "git symbolic-ref -d refs/symref" &&
+	git symbolic-ref refs/symref refs/heads/$GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME &&
+	${git_show_ref_exists} refs/symref
+'
+
+test_expect_success '--exists with dangling symref' '
+	test_when_finished "git symbolic-ref -d refs/heads/dangling" &&
+	git symbolic-ref refs/heads/dangling refs/heads/does-not-exist &&
+	${git_show_ref_exists} refs/heads/dangling
+'
+
+test_expect_success '--exists with nonexistent object ID' '
+	test-tool ref-store main update-ref msg refs/heads/missing-oid $(test_oid 001) $ZERO_OID REF_SKIP_OID_VERIFICATION &&
+	${git_show_ref_exists} refs/heads/missing-oid
+'
+
+test_expect_success '--exists with non-commit object' '
+	tree_oid=$(git rev-parse HEAD^{tree}) &&
+	test-tool ref-store main update-ref msg refs/heads/tree ${tree_oid} $ZERO_OID REF_SKIP_OID_VERIFICATION &&
+	${git_show_ref_exists} refs/heads/tree
+'
+
+test_expect_success '--exists with directory fails with generic error' '
+	cat >expect <<-EOF &&
+	error: reference does not exist
+	EOF
+	test_expect_code 2 ${git_show_ref_exists} refs/heads 2>err &&
+	test_cmp expect err
+'
+
+test_expect_success '--exists with non-existent special ref' '
+	test_expect_code 2 ${git_show_ref_exists} FETCH_HEAD
+'
+
+test_expect_success '--exists with existing special ref' '
+	test_when_finished "rm .git/FETCH_HEAD" &&
+	git rev-parse HEAD >.git/FETCH_HEAD &&
+	${git_show_ref_exists} FETCH_HEAD
+'
diff --git a/t/t1403-show-ref.sh b/t/t1403-show-ref.sh
index 9da3650e91..dbae82384b 100755
--- a/t/t1403-show-ref.sh
+++ b/t/t1403-show-ref.sh
@@ -228,69 +228,5 @@ test_expect_success 'show-ref sub-modes are mutually exclusive' '
 	grep "cannot be used together" err
 '
 
-test_expect_success '--exists with existing reference' '
-	git show-ref --exists refs/heads/$GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
-'
-
-test_expect_success '--exists with missing reference' '
-	test_expect_code 2 git show-ref --exists refs/heads/does-not-exist
-'
-
-test_expect_success '--exists does not use DWIM' '
-	test_expect_code 2 git show-ref --exists $GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME 2>err &&
-	grep "reference does not exist" err
-'
-
-test_expect_success '--exists with HEAD' '
-	git show-ref --exists HEAD
-'
-
-test_expect_success '--exists with bad reference name' '
-	test_when_finished "git update-ref -d refs/heads/bad...name" &&
-	new_oid=$(git rev-parse HEAD) &&
-	test-tool ref-store main update-ref msg refs/heads/bad...name $new_oid $ZERO_OID REF_SKIP_REFNAME_VERIFICATION &&
-	git show-ref --exists refs/heads/bad...name
-'
-
-test_expect_success '--exists with arbitrary symref' '
-	test_when_finished "git symbolic-ref -d refs/symref" &&
-	git symbolic-ref refs/symref refs/heads/$GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME &&
-	git show-ref --exists refs/symref
-'
-
-test_expect_success '--exists with dangling symref' '
-	test_when_finished "git symbolic-ref -d refs/heads/dangling" &&
-	git symbolic-ref refs/heads/dangling refs/heads/does-not-exist &&
-	git show-ref --exists refs/heads/dangling
-'
-
-test_expect_success '--exists with nonexistent object ID' '
-	test-tool ref-store main update-ref msg refs/heads/missing-oid $(test_oid 001) $ZERO_OID REF_SKIP_OID_VERIFICATION &&
-	git show-ref --exists refs/heads/missing-oid
-'
-
-test_expect_success '--exists with non-commit object' '
-	tree_oid=$(git rev-parse HEAD^{tree}) &&
-	test-tool ref-store main update-ref msg refs/heads/tree ${tree_oid} $ZERO_OID REF_SKIP_OID_VERIFICATION &&
-	git show-ref --exists refs/heads/tree
-'
-
-test_expect_success '--exists with directory fails with generic error' '
-	cat >expect <<-EOF &&
-	error: reference does not exist
-	EOF
-	test_expect_code 2 git show-ref --exists refs/heads 2>err &&
-	test_cmp expect err
-'
-
-test_expect_success '--exists with non-existent special ref' '
-	test_expect_code 2 git show-ref --exists FETCH_HEAD
-'
-
-test_expect_success '--exists with existing special ref' '
-	test_when_finished "rm .git/FETCH_HEAD" &&
-	git rev-parse HEAD >.git/FETCH_HEAD &&
-	git show-ref --exists FETCH_HEAD
-'
-
+. "$TEST_DIRECTORY"/show-ref-exists-tests.sh
 test_done
diff --git a/t/t1462-refs-exists.sh b/t/t1462-refs-exists.sh
new file mode 100755
index 0000000000..c00d76cc9e
--- /dev/null
+++ b/t/t1462-refs-exists.sh
@@ -0,0 +1,22 @@
+#!/bin/sh
+
+test_description='refs exists'
+GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
+export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
+
+. ./test-lib.sh
+
+git_show_ref_exists='git refs exists'
+
+test_expect_success setup '
+	test_commit --annotate A &&
+	git checkout -b side &&
+	test_commit --annotate B &&
+	git checkout main &&
+	test_commit C &&
+	git branch B A^0
+'
+
+. "$TEST_DIRECTORY"/show-ref-exists-tests.sh
+
+test_done

-- 
2.34.1
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 4 of 23 in “Add refs exists subcommand”
  1. Meet SoniAug 21, 2025
  2. [GSoC][PATCH 1/2] builtin/refs: add 'exists' subcommandMeet Soni, Aug 21, 2025
  3. Patrick SteinhardtAug 21, 2025
  4. [GSoC][PATCH 2/2] t: add test for git refs exists subcommandMeet Soni, Aug 21, 2025
  5. Patrick SteinhardtAug 21, 2025
  6. Meet SoniAug 22, 2025
  7. Patrick SteinhardtAug 21, 2025
  8. Junio C HamanoAug 21, 2025
  9. Meet SoniAug 22, 2025
  10. [GSoC][PATCH v2 0/4] Add refs exists subcommandMeet Soni, Aug 23, 2025
  11. [GSoC][PATCH v2 1/4] builtin/refs: add 'exists' subcommandMeet Soni, Aug 23, 2025
  12. [GSoC][PATCH v2 2/4] t1403: split 'show-ref --exists' tests into a separate fileMeet Soni, Aug 23, 2025
  13. [GSoC][PATCH v2 3/4] t1422: refactor tests to be shareableMeet Soni, Aug 23, 2025
  14. Patrick SteinhardtAug 24, 2025
  15. [GSoC][PATCH v2 4/4] t: add test for git refs exists subcommandMeet Soni, Aug 23, 2025
  16. Patrick SteinhardtAug 24, 2025
  17. [GSoC][PATCH v3 0/4] Add refs exists subcommandMeet Soni, Aug 26, 2025
  18. [GSoC][PATCH v3 1/4] builtin/refs: add 'exists' subcommandMeet Soni, Aug 26, 2025
  19. [GSoC][PATCH v3 2/4] t1403: split 'show-ref --exists' tests into a separate fileMeet Soni, Aug 26, 2025
  20. [GSoC][PATCH v3 3/4] t1422: refactor tests to be shareableMeet Soni, Aug 26, 2025
  21. [GSoC][PATCH v3 4/4] t: add test for git refs exists subcommandMeet Soni, Aug 26, 2025
  22. Patrick SteinhardtSep 2, 2025
  23. Junio C HamanoSep 2, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.