git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] t/t1517: mark tests that fail with GIT_TEST_INSTALLED

From
Adam Dinwoodie <adam@dinwoodie.org>
Date
Aug 19, 2025, 07:43 UTC
Message-ID
<20250819074631.3303-1-adam@dinwoodie.org>
In-Reply-To
<20250816103656.1693607-1-adam@dinwoodie.org>

The changes added by 39fc408562 (t/t1517: automate `git subcmd -h` tests outside a repository, 2025-08-08) to automatically loop over all "main" Git commands will, when run against an installed build using GIT_TEST_INSTALLED rather than the build in the build directory, include some extra git-gui commands that are installed by `make install`, or credential helpers that might be installed manually from the contrib directories. These fail the test, so record them as such.

Signed-off-by: Adam Dinwoodie <adam@dinwoodie.org>
---

This re-roll adds a few more commands to those marked as known failures, notably credential helpers I see installed in various builds for the Nixpkgs packaging of Git.

 t/t1517-outside-repo.sh | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/t/t1517-outside-repo.sh b/t/t1517-outside-repo.sh
index 1c69d52c76..c824c1a25c 100755
--- a/t/t1517-outside-repo.sh
+++ b/t/t1517-outside-repo.sh
@@ -111,8 +111,11 @@ for cmd in $(git --list-cmds=main)
 do
 	cmd=${cmd%.*} # strip .sh, .perl, etc.
 	case "$cmd" in
-	archimport | cvsexportcommit | cvsimport | cvsserver | daemon | \
+	archimport | citool | credential-netrc | credential-libsecret | \
+	credential-osxkeychain | cvsexportcommit | cvsimport | cvsserver | \
+	daemon | \
 	difftool--helper | filter-branch | fsck-objects | get-tar-commit-id | \
+	gui | gui--askpass | \
 	http-backend | http-fetch | http-push | init-db | \
 	merge-octopus | merge-one-file | merge-resolve | mergetool | \
 	mktag | p4 | p4.py | pickaxe | remote-ftp | remote-ftps | \
-- 
2.49.0
Previous: Usman AkinyemiNext: Junio C Hamano
Message 3 of 5 in “t/t1517: mark tests that fail with GIT_TEST_INSTALLED”
  1. t/t1517: mark tests that fail with GIT_TEST_INSTALLEDAdam Dinwoodie, Aug 16, 2025
  2. Usman AkinyemiAug 17, 2025
  3. t/t1517: mark tests that fail with GIT_TEST_INSTALLEDAdam Dinwoodie, Aug 19, 2025
  4. Junio C HamanoAug 19, 2025
  5. Adam DinwoodieAug 19, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.