Re: [PATCH v4 1/1] test-delta: simplify delta helper with strbuf and better cleanup

From: Jeff King <peff@peff.net>
Date: Jul 25, 2025, 11:16 UTC
Message-ID: <20250725111634.GA3015176@coredump.intra.peff.net>
In-Reply-To: <20250725111530.GA3015021@coredump.intra.peff.net>

On Fri, Jul 25, 2025 at 07:15:31AM -0400, Jeff King wrote:

Show 11 quoted lines

> On Thu, Jul 24, 2025 at 11:09:55AM -0700, Junio C Hamano wrote:
> 
> > OK.  Except for the whitespace breakage, I didn't spot anything
> > glaringly wrong in the patch.  Looking good.
> 
> Hmm. This looks like just a squash of the 3-patch series I sent earlier?
> 
> (Sorry, it was in another part of the thread and you weren't on the cc).
> 
> If we are going to go in this direction, I'd prefer to leave it split
> into the 3 more obvious patches with explanations.

Probably would have been helpful to actually provide a link:

  https://lore.kernel.org/git/20250723235929.GB592873@coredump.intra.peff.net/

-Peff