Re: [PATCH v3 2/2] t/helper/test-delta: fix possible resource leak and ensure safe cleanup

From: Jeff King <peff@peff.net>
Date: Jul 23, 2025, 08:46 UTC
Message-ID: <20250723084624.GA580010@coredump.intra.peff.net>
In-Reply-To: <CAPig+cQ2p3muA0-8O_u-rOW0uVGQ_ZE7hcz-7qq8M1U+PdvtpQ@mail.gmail.com>

On Wed, Jul 23, 2025 at 04:11:26AM -0400, Eric Sunshine wrote:

> For completeness, I'll mention that I even had the thought that
> another "fix" would be to tear out all the cleanup code entirely since
> we _know_ that this function will be exiting immediately and the OS
> will clean up any dangling resources.

The reason we have the "cleanup" label at all is because of the memory leaks. And there the issue is that we build the test helpers with the same compiler settings as the rest of the code, so SANITIZE=leak will complain. So I think that is a non-starter.

But if you just meant leaking descriptors, sure, I don't think any tools complain about that. ;)

-Peff