git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 0/5] bswap.h: Rework ntohl handling

From
Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Date
Jul 15, 2025, 19:12 UTC
Message-ID
<20250715191230.12081-1-sebastian@breakpoint.cc>
Hi,
this series continues the rework of the bswap32/64()/ nothl() handling. 

I've been looking at recent compiler and they manage to recognize the manual shifting and use an optimize opcode if available. The ntohl version provided by glibc already provides an "optimized" version which makes an optimisation in git almost not needed. One of the motivation behind overwriting/ providing an optimized version was to provide a macro instead of using a function call. One libc that is still providing ntohl as a function call is musl.

While ntohl() is provided by the libc, the ntohll() is not. I found it only on Windows provided by winsock.h.

I haven't touched the put/get_be*() macros. gcc & clang are both smart enough to swap the content accordingly and perform a single store/ load. Only the msvc seems to strugle here and performs multiple bytes stores/ loads and shifts.

v2…v3 https://lore.kernel.org/all/20250611221444.1567638-1-sebastian@breakpoint.cc/
  - Fixed typos in the patch description
Sebastian Andrzej Siewior (5):
  bswap.h: Add support for __BYTE_ORDER__
  bswap.h: Define GIT_LITTLE_ENDIAN on msvc as little endian
  bswap.h: Always overwrite ntohl/ ntohll macros
  bswap.h: Remove optimized x86 version of bswap32/64
  bswap.h: Provide a built-in based version of bswap32/64 if possible
 compat/bswap.h | 114 +++++++++++++++++++++----------------------------
 1 file changed, 48 insertions(+), 66 deletions(-)
-- 
2.50.0
Next: Sebastian Andrzej Siewior
Message 1 of 9 in “bswap.h: Rework ntohl handling”
  1. 0/5 bswap.h: Rework ntohl handlingSebastian Andrzej Siewior, Jul 15, 2025
  2. 1/5 bswap.h: Add support for __BYTE_ORDER__Sebastian Andrzej Siewior, Jul 15, 2025
  3. 4/5 bswap.h: Remove optimized x86 version of bswap32/64Sebastian Andrzej Siewior, Jul 15, 2025
  4. 5/5 bswap.h: Provide a built-in based version of bswap32/64 if possibleSebastian Andrzej Siewior, Jul 15, 2025
  5. 2/5 bswap.h: Define GIT_LITTLE_ENDIAN on msvc as little endianSebastian Andrzej Siewior, Jul 15, 2025
  6. 3/5 bswap.h: Always overwrite ntohl/ ntohll macrosSebastian Andrzej Siewior, Jul 15, 2025
  7. Junio C HamanoJul 15, 2025
  8. brian m. carlsonJul 15, 2025
  9. Sebastian Andrzej SiewiorJul 16, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.