Re: [PATCH v2 5/6] bswap.h: Remove optimized x86 version of bswap32/64
On 2025-06-26 17:55:43 [+0200], Kristoffer Haugsbakk wrote:
Show 24 quoted lines
> On Thu, Jun 12, 2025, at 00:14, Sebastian Andrzej Siewior wrote:
> > On x86 the bswap32/64 macro is implemenated based on the x86 opcode wich
>
> s/implemenated/implemented/
>
> s/wich/which/
>
> > performs the required shifting in just one opcode.
> > The other CPUs fallback to the generic shifting as implemented by
> > default_swab32() and default_bswap64() if needed.
> >
> > I've been looking at how good a compiler is at recognizing the default
> > shift and emitting an optimized operation:
> > - x86, arm64 msvc v19.20
> > default_swab32() optimized
> > default_bswap64() shifts
> > _byteswap_uint64() otimized
> >
> > - x86, arm64 msvc v19.37
> > default_swab32() optimized
> > default_bswap64() optimized
> > _byteswap_uint64() otimized
>
> Is it supposed to say `otimized` twice?
Nope. Fixed. Thank you.
Sebastian