Re: Bug: "git stash create" ignores "message" argument

From: Jeff King <peff@peff.net>
Date: Jul 8, 2025, 22:50 UTC
Message-ID: <20250708225007.GA1180568@coredump.intra.peff.net>
In-Reply-To: <xmqqv7o2vc64.fsf@gitster.g>

On Tue, Jul 08, 2025 at 10:13:07AM -0700, Junio C Hamano wrote:

Show 14 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> >   2. Possibly "stash store" could pull the default message from the
> >      commit, rather than using the generic one.
> 
> This might be a good compromise.  Even we discourage the use of
> "store" and "create" combo to interactive users, we do care about
> ergonomics for script writers.
> 
> Those who use "create" to write a detailed log message (which may
> later be reused for a real commit that is created out of the stashed
> changes) would end up with a huge and unpleasant stash entries if
> they use "store" without any message, which may be a negative
> experinece for them, though.

I'd feel a bit better about tweaking the ergonomics of "stash store" if I thought it was generally useful to script writers. But it appears to have been created solely as an implementation detail of rebase.autostash, and I do not recall ever hearing of anybody using it in the 12 years since.

I.e., without understanding why somebody would want to use it in the first place, I don't know what potential we have to disrupt them by switching the behavior (and nor am I all that excited to spend time working on it. ;) ).

Maybe José can tell us a bit more about his use case.

-Peff