git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/7] t/t1517: move ls-files -h test to t1517

From
Usman Akinyemi <usmanakinyemi202@gmail.com>
Date
Jul 6, 2025, 21:07 UTC
Message-ID
<20250706210725.79903-4-usmanakinyemi202@gmail.com>
In-Reply-To
<20250706210725.79903-1-usmanakinyemi202@gmail.com>

The test 'ls-files does not crash with -h' checks that the command exits cleanly with usage information, both inside and outside of a repository.

Move this test from "t3004-ls-files-basic.sh" to "t1517-outside-repo.sh" since it better fits with tests that check command behavior outside a repository.

Suggested-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>
---
 t/t1517-outside-repo.sh   | 7 +++++++
 t/t3004-ls-files-basic.sh | 7 -------
 2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/t/t1517-outside-repo.sh b/t/t1517-outside-repo.sh
index 92ad159b58..e04be2d811 100755
--- a/t/t1517-outside-repo.sh
+++ b/t/t1517-outside-repo.sh
@@ -128,4 +128,11 @@ test_expect_success 'for-each-ref does not crash with -h' '
 	test_grep "[Uu]sage: git for-each-ref " usage
 '
 
+test_expect_success 'ls-files does not crash with -h' '
+	test_expect_code 129 git ls-files -h >usage &&
+	test_grep "[Uu]sage: git ls-files " usage &&
+	test_expect_code 129 nongit git ls-files -h >usage &&
+	test_grep "[Uu]sage: git ls-files " usage
+'
+
 test_done
diff --git a/t/t3004-ls-files-basic.sh b/t/t3004-ls-files-basic.sh
index 4034a5a59f..a1078f8701 100755
--- a/t/t3004-ls-files-basic.sh
+++ b/t/t3004-ls-files-basic.sh
@@ -34,13 +34,6 @@ test_expect_success 'ls-files -h in corrupt repository' '
 	test_grep "[Uu]sage: git ls-files " broken/usage
 '
 
-test_expect_success 'ls-files does not crash with -h' '
-	test_expect_code 129 git ls-files -h >usage &&
-	test_grep "[Uu]sage: git ls-files " usage &&
-	test_expect_code 129 nongit git ls-files -h >usage &&
-	test_grep "[Uu]sage: git ls-files " usage
-'
-
 test_expect_success SYMLINKS 'ls-files with absolute paths to symlinks' '
 	mkdir subs &&
 	ln -s nosuch link &&
-- 
2.50.0
Previous: Usman AkinyemiNext: Usman Akinyemi
Message 4 of 8 in “move builtin help test to t1517”
  1. 0/7 move builtin help test to t1517Usman Akinyemi, Jul 6, 2025
  2. 1/7 t/t1517: move checkout-index -h test to t1517Usman Akinyemi, Jul 6, 2025
  3. 2/7 t/t1517: move for-each-ref -h test to t1517Usman Akinyemi, Jul 6, 2025
  4. 3/7 t/t1517: move ls-files -h test to t1517Usman Akinyemi, Jul 6, 2025
  5. 4/7 t/t1517: move pack-refs -h test to t1517Usman Akinyemi, Jul 6, 2025
  6. 5/7 t/t1517: move send-pack -h test to t1517Usman Akinyemi, Jul 6, 2025
  7. 6/7 t/t1517: move verify-commit -h test to t1517Usman Akinyemi, Jul 6, 2025
  8. 7/7 t/t1517: move verify-tag -h test to t1517Usman Akinyemi, Jul 6, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.