git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 2/2] build: retire NO_UINTMAX_T

From
Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date
Jul 2, 2025, 09:37 UTC
Message-ID
<20250702093736.36074-3-carenas@gmail.com>
In-Reply-To
<20250702093736.36074-1-carenas@gmail.com>

A previous commit removed the last user of it, and it is no longer useful with the codebase moving towards C99, which specifies its definition.

Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
---
 Makefile     |  5 -----
 configure.ac |  8 --------
 meson.build  | 11 -----------
 3 files changed, 24 deletions(-)
diff --git a/Makefile b/Makefile
index 3868edd349..ba111f191f 100644
--- a/Makefile
+++ b/Makefile
@@ -114,8 +114,6 @@ include shared.mak
 #
 # Define NO_INTPTR_T if you don't have intptr_t or uintptr_t.
 #
-# Define NO_UINTMAX_T if you don't have uintmax_t.
-#
 # Define NEEDS_SOCKET if linking with libc is not enough (SunOS,
 # Patrick Mauritz).
 #
@@ -1915,9 +1913,6 @@ endif
 ifdef NO_INTPTR_T
 	COMPAT_CFLAGS += -DNO_INTPTR_T
 endif
-ifdef NO_UINTMAX_T
-	BASIC_CFLAGS += -Duintmax_t=uint32_t
-endif
 ifdef NO_SOCKADDR_STORAGE
 ifdef NO_IPV6
 	BASIC_CFLAGS += -Dsockaddr_storage=sockaddr_in
diff --git a/configure.ac b/configure.ac
index 5923edc44a..d8c3af161b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1121,14 +1121,6 @@ GIT_CHECK_FUNC(strlcpy,
 [NO_STRLCPY=YesPlease])
 GIT_CONF_SUBST([NO_STRLCPY])
 #
-# Define NO_UINTMAX_T if your platform does not have uintmax_t
-AC_CHECK_TYPE(uintmax_t,
-[NO_UINTMAX_T=],
-[NO_UINTMAX_T=YesPlease],[
-#include <inttypes.h>
-])
-GIT_CONF_SUBST([NO_UINTMAX_T])
-#
 # Define NO_STRTOUMAX if you don't have strtoumax in the C library.
 GIT_CHECK_FUNC(strtoumax,
 [NO_STRTOUMAX=],
diff --git a/meson.build b/meson.build
index efe2871c9d..27d5f40741 100644
--- a/meson.build
+++ b/meson.build
@@ -1331,17 +1331,6 @@ if compiler.compiles('''
   libgit_c_args += '-DHAVE_CLOCK_MONOTONIC'
 endif
 
-if not compiler.compiles('''
-  #include <inttypes.h>
-
-  void func(void)
-  {
-    uintmax_t x = 0;
-  }
-''', name: 'uintmax_t')
-  libgit_c_args += '-DNO_UINTMAX_T'
-endif
-
 has_bsd_sysctl = false
 if compiler.has_header('sys/sysctl.h')
   if compiler.compiles('''
-- 
2.50.0.147.gafe0d4ec5b
Previous: Carlo Marcelo Arenas BelónNext: Junio C Hamano
Message 9 of 11 in “Re: [PATCH v2] config.mak.uname: update settings for FreeBSD”
  1. Carlo ArenasJun 12, 2025
  2. brian m. carlsonJun 12, 2025
  3. Carlo Marcelo Arenas BelónJun 12, 2025
  4. config.mak.uname: update settings for FreeBSDJunio C Hamano, Jun 12, 2025
  5. Carlo Marcelo Arenas BelónJun 12, 2025
  6. Junio C HamanoJun 12, 2025
  7. 0/2 config.mak.uname: update settings for FreeBSDCarlo Marcelo Arenas Belón, Jul 2, 2025
  8. 1/2 config.mak.uname: set NO_MEMMEM only for functional versionCarlo Marcelo Arenas Belón, Jul 2, 2025
  9. 2/2 build: retire NO_UINTMAX_TCarlo Marcelo Arenas Belón, Jul 2, 2025
  10. Junio C HamanoJul 2, 2025
  11. Junio C HamanoJun 12, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.