[PATCH] daemon: correctly handle soft accept() errors
- From
Carlo Marcelo Arenas Belón <carenas@gmail.com>
- Date
- Jun 26, 2025, 16:10 UTC
- Message-ID
- <20250626161038.85966-1-carenas@gmail.com>
Since df076bdbcc ([PATCH] GIT: Listen on IPv6 as well, if available., 2005-07-23), the original error checking was included in an inner loop unchanged, where its effect was different.
Instead of retrying, after a EINTR during accept() in the listening socket, it will advance to the next one and try with that instead, leaving the client waiting for another round.
Make sure that the loop doesn't advance and while at it, make sure that any possible completed childs get reaped earlier. To avoid an unlilely busy loop, fallback to the old behaviour after a couple of attempts.
Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com> --- daemon.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/daemon.c b/daemon.c index d1be61fd57..8d02099a4e 100644 --- a/daemon.c +++ b/daemon.c @@ -1153,11 +1153,21 @@ static int service_loop(struct socketlist *socklist) #endif } ss; socklen_t sslen = sizeof(ss); - int incoming = accept(pfd[i].fd, &ss.sa, &sslen); + int incoming; + +redo: + incoming = accept(pfd[i].fd, &ss.sa, &sslen); if (incoming < 0) { + int retry = 2; + switch (errno) { - case EAGAIN: case EINTR: + if (--retry) { + check_dead_children(); + goto redo; + } + /* fallthrough */ + case EAGAIN: case ECONNABORTED: continue; default:
-- 2.50.0.132.gb7f585ac00