Re: [PATCH 1/2] t7422: replace confusing printf with echo

From: Jeff King <peff@peff.net>
Date: Jun 24, 2025, 10:05 UTC
Message-ID: <20250624100520.GA636332@coredump.intra.peff.net>
In-Reply-To: <CAPig+cSLJ57+ZU1TreHajAqbQwBD7TRUt3bxRDTcHCjS88xmLg@mail.gmail.com>

On Mon, Jun 23, 2025 at 01:59:48PM -0400, Eric Sunshine wrote:

Show 12 quoted lines

> > diff --git a/t/t7422-submodule-output.sh b/t/t7422-submodule-output.sh
> > @@ -180,7 +180,8 @@ test_expect_success !MINGW 'git submodule status --recursive propagates SIGPIPE'
> > -                       printf "[submodule \"sm-$i\"]\npath = recursive-submodule-path-$i\n" "$i" ||
> > +                       echo "[submodule \"sm-$i\"]" &&
> > +                       echo "path = recursive-submodule-path-$i" ||
> 
> This looks obviously correct and, as the commit message says, is
> almost certainly easier to read, but I was more than a little
> surprised to see the patch since I thought this code had been fixed
> previously[*] and had some discussion around it.
> 
> [*] https://lore.kernel.org/git/20250403144852.19153-1-sn03.general@gmail.com/

Ah, interesting, I hadn't seen that one. I am happy with either solution, but IMHO what I posted with "echo" is a bit more readable.

-Peff