git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] cat-file: add %(objectmode) and submodule message to batch commands

From
Jeff King <peff@peff.net>
Date
Jun 4, 2025, 19:57 UTC
Message-ID
<20250604195701.GC1500045@coredump.intra.peff.net>
In-Reply-To
<xmqqh60vefee.fsf@gitster.g>
On Wed, Jun 04, 2025 at 07:43:21AM -0700, Junio C Hamano wrote:
Show 10 quoted lines
> > The final patch takes a different approach to submodule resolution than the
> > initial submission; rather than treat the entry as a "regular" commit object
> > with empty content, we now print an error message similar to the "missing",
> > "ambiguous", etc. cases, but with the tree entry's OID rather than the input
> > object name.
> 
> I did not send any line-by-line reviews, but after reading these
> patches I didn't see anything questionable.  Unless we see others
> comments that need to be addressed, let's merge it to 'next' in
> preparation for the next cycle.

I left a more detailed review. But it's mostly musing and self-answering questions. I'd be OK to see this progress as-is.

-Peff
Previous: Junio C Hamano
Message 10 of 10 in “cat-file: add %(objectmode) and submodule message to batch commands”
  1. 0/3 cat-file: add %(objectmode) and submodule message to batch commandsVictoria Dye via GitGitGadget, Jun 2, 2025
  2. 1/3 t1006: update 'run_tests' to test generic object specifiersVictoria Dye via GitGitGadget, Jun 2, 2025
  3. 2/3 cat-file: add %(objectmode) atomVictoria Dye via GitGitGadget, Jun 2, 2025
  4. Jeff KingJun 4, 2025
  5. 3/3 cat-file.c: add batch handling for submodulesVictoria Dye via GitGitGadget, Jun 2, 2025
  6. Jeff KingJun 4, 2025
  7. Victoria DyeJun 5, 2025
  8. Jeff KingJun 5, 2025
  9. Junio C HamanoJun 4, 2025
  10. Jeff KingJun 4, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.