Re: [PATCH 0/3] cat-file: add %(objectmode) and submodule message to batch commands
- From
Jeff King <peff@peff.net>
- Date
- Jun 4, 2025, 19:57 UTC
- Message-ID
- <20250604195701.GC1500045@coredump.intra.peff.net>
- In-Reply-To
- <xmqqh60vefee.fsf@gitster.g>
On Wed, Jun 04, 2025 at 07:43:21AM -0700, Junio C Hamano wrote:
Show 10 quoted lines
> > The final patch takes a different approach to submodule resolution than the > > initial submission; rather than treat the entry as a "regular" commit object > > with empty content, we now print an error message similar to the "missing", > > "ambiguous", etc. cases, but with the tree entry's OID rather than the input > > object name. > > I did not send any line-by-line reviews, but after reading these > patches I didn't see anything questionable. Unless we see others > comments that need to be addressed, let's merge it to 'next' in > preparation for the next cycle.
I left a more detailed review. But it's mostly musing and self-answering questions. I'd be OK to see this progress as-is.
-Peff